From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54646) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZ1j4-0002Gu-AA for qemu-devel@nongnu.org; Mon, 28 May 2012 11:19:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SZ1ip-0002tK-Ov for qemu-devel@nongnu.org; Mon, 28 May 2012 11:19:17 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56246 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZ1ip-0002ou-8j for qemu-devel@nongnu.org; Mon, 28 May 2012 11:19:03 -0400 Message-ID: <4FC39760.9030800@suse.de> Date: Mon, 28 May 2012 17:18:56 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1338136940-53279-1-git-send-email-andreas.faerber@web.de> <4FC365D6.80205@web.de> In-Reply-To: <4FC365D6.80205@web.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-1.1? v2] slirp: Avoid statements without effect on Big Endian host List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka , Peter Maydell Cc: qemu-devel@nongnu.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 28.05.2012 13:47, schrieb Jan Kiszka: > On 2012-05-28 00:10, Peter Maydell wrote: >> On 27 May 2012 17:42, Andreas F=C3=A4rber >> wrote: >>> +# if defined(__APPLE__) +# undef NTOHL +# undef NTOHS +# >>> undef HTONL +# undef HTONS +# define NTOHL(d) do { } while >>> (0) +# define NTOHS(d) do { } while (0) +# define HTONL(d) do >>> { } while (0) +# define HTONS(d) do { } while (0) +# else >>=20 >> We could just use this for everything, not just if __APPLE__,=20 >> right? For big-endian the semantics we want are always "do=20 >> nothing" so it's always OK to undef and redefine... That would >> save having a special case. >=20 > Yes, please. On second thoughts my v2 was totally unnecessary and the solution flawed: The HTONS(x); warning is stemming from Apple's #define HTONS(d) (d) not from our #define HTONS(d) so we can just unconditionally #undef the existing definitions. That'll lead to unnecessary semicolons but not to warnings. Andreas - --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (GNU/Linux) iQIcBAEBAgAGBQJPw5dgAAoJEPou0S0+fgE/wIkP/iu4ZQMR22nukCvtXANu2G7b QfnsM7w28zRS2y+RkpoQ4pdldD5o2PMVowUA8uGtscvO4o5wVn7/h+1z768NFMht KeOAic2h1cDUMQZp5DIhuMwXNHtzrYKejxyJSWzVFdpT+Za8tecQ4ge+iDXObdL0 u2a5RAfZU5oPSLZYdUWHkQhf6GayXRvkr/o6rBHKi0Y6S/Du9vlNUpMcANg1O85E LtraZbfikfKAtWxX+3+yTaNmpfylbYTnUQqHGEXcwMSr7TIDstoyf1kmQcrOacQa KwOGfW0psRsLQHSb9c3msezo4bFM/S+hyLj3Qg/Cr6Va/jENiyHUNALSymRCvlNw nVTZOPoNfYOYHnu7yR7xTjpIxngCL7vtdjw4RhJASVKZXQo1TzeAgi9Wx/LFGuFa Kifqr1wQwSUm+BESMAtJMKixobMscm1rkcwsITuAxTR+l6Cp6X3FcOG9xuHWbT52 IBToxsapwkRNdrb5HZxRIufOvTUq6j/zRfpODqiYe5IoHhF25w4Cvx5+eJ8X7Up6 2RrWRwtj6lmkBhezp2yiBZ/nIUVDcD8jywllla3PS52rjwJoFvRfAU9551yZPMkP sVhSdID9f9KzwzzUE8YfcCGaVFnOriJG5LikxqcRztp7nlKSPFQNA0DvTK3xTuez TzrCEwLr6wtBcdvG+6CK =3D0bsI -----END PGP SIGNATURE-----