From: Jonathan Cameron <jic23@cam.ac.uk>
To: michael.hennerich@analog.com
Cc: jic23@kernel.org, linux-iio@vger.kernel.org,
device-drivers-devel@blackfin.uclinux.org
Subject: Re: [PATCH v3] iio: frequency: New driver for AD9523 SPI Low Jitter Clock Generator
Date: Tue, 29 May 2012 11:34:30 +0100 [thread overview]
Message-ID: <4FC4A636.3000609@cam.ac.uk> (raw)
In-Reply-To: <1338285197-15439-1-git-send-email-michael.hennerich@analog.com>
On 5/29/2012 10:53 AM, michael.hennerich@analog.com wrote:
> From: Michael Hennerich<michael.hennerich@analog.com>
>
> Changes since V1:
>
> Apply Jonathan's review feedback:
> Revise device status attribute names, and split documentation into two sections.
> Add additional comments, and fix indention issues.
> Remove pointless zero initializations.
> Revise return value handling.
> Simplify some code sections.
> Split store_eeprom and sync handling into separate functions.
> Use strtobool where applicable.
> Document platform data structures using kernel-doc style.
>
> Use dev_to_iio_dev
> write_raw IIO_CHAN_INFO_FREQUENCY: Reject values<= 0
> Make patch target drivers/iio
>
> Changes since V2:
>
> Use for_each_clear_bit() and __set_bit() where applicable.
> Add descriptive comment.
> Avoid temporary for struct regulator.
> spi_device_id name use ad9523-1, ad9523 will be added later.
>
> Signed-off-by: Michael Hennerich<michael.hennerich@analog.com>
Acked-by: Jonathan Cameron <jic23@kernel.org>
> ---
> .../ABI/testing/sysfs-bus-iio-frequency-ad9523 | 37 +
> drivers/iio/Kconfig | 1 +
> drivers/iio/Makefile | 1 +
> drivers/iio/frequency/Kconfig | 23 +
> drivers/iio/frequency/Makefile | 5 +
> drivers/iio/frequency/ad9523.c | 1057 ++++++++++++++++++++
> include/linux/iio/frequency/ad9523.h | 195 ++++
> 7 files changed, 1319 insertions(+), 0 deletions(-)
> create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-frequency-ad9523
> create mode 100644 drivers/iio/frequency/Kconfig
> create mode 100644 drivers/iio/frequency/Makefile
> create mode 100644 drivers/iio/frequency/ad9523.c
> create mode 100644 include/linux/iio/frequency/ad9523.h
>
prev parent reply other threads:[~2012-05-29 10:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-29 9:53 [PATCH v3] iio: frequency: New driver for AD9523 SPI Low Jitter Clock Generator michael.hennerich
2012-05-29 10:34 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC4A636.3000609@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=michael.hennerich@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.