From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Lin Ming <ming.m.lin@intel.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
David Woodhouse <David.Woodhouse@intel.com>,
Aaron Lu <aaron.lu@amd.com>, Holger Macht <holger@homac.de>,
Matthew Garrett <mjg@redhat.com>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH v4 01/13] [SCSI]: add wrapper to access and set scsi_bus_type in struct acpi_bus_type
Date: Tue, 29 May 2012 16:26:17 +0400 [thread overview]
Message-ID: <4FC4C069.1000906@mvista.com> (raw)
In-Reply-To: <1338181720-4149-2-git-send-email-ming.m.lin@intel.com>
Hello.
On 28-05-2012 9:08, Lin Ming wrote:
> From: Holger Macht<holger@homac.de>
> For being able to bind ata devices against acpi devices, scsi_bus_type
> needs to be set as bus in struct acpi_bus_type. So add wrapper to
> scsi_lib to accomplish that.
> Signed-off-by: Holger Macht<holger@homac.de>
> Signed-off-by: Lin Ming<ming.m.lin@intel.com>
> ---
> drivers/scsi/scsi_lib.c | 17 +++++++++++++++++
> include/scsi/scsi.h | 10 ++++++++++
> 2 files changed, 27 insertions(+), 0 deletions(-)
> diff --git a/include/scsi/scsi.h b/include/scsi/scsi.h
> index f34a5a8..4527b3a 100644
> --- a/include/scsi/scsi.h
> +++ b/include/scsi/scsi.h
> @@ -214,6 +214,16 @@ scsi_command_size(const unsigned char *cmnd)
> scsi_varlen_cdb_length(cmnd) : COMMAND_SIZE(cmnd[0]);
> }
>
> +#ifdef CONFIG_ACPI
You don't have to enclode declarations into #ifdef.
> +struct acpi_bus_type;
> +
> +extern int
'extern' is the default memory class for function, no need to specidy it.
And don't break the line here.
> +scsi_register_acpi_bus_type(struct acpi_bus_type *bus);
> +
> +extern void
Same comment.
> +scsi_unregister_acpi_bus_type(struct acpi_bus_type *bus);
> +#endif
MBR, Sergei
next prev parent reply other threads:[~2012-05-29 12:26 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-28 5:08 [PATCH v4 0/13] SATA ZPODD support Lin Ming
2012-05-28 5:08 ` [PATCH v4 01/13] [SCSI]: add wrapper to access and set scsi_bus_type in struct acpi_bus_type Lin Ming
2012-05-29 12:26 ` Sergei Shtylyov [this message]
2012-05-28 5:08 ` [PATCH v4 02/13] libata: bind the Linux device tree to the ACPI device tree Lin Ming
2012-05-28 9:51 ` Alan Cox
2012-06-13 8:03 ` Lin Ming
2012-06-13 11:00 ` Alan Cox
2012-06-13 11:00 ` Alan Cox
2012-06-14 7:43 ` Lin Ming
2012-05-28 5:08 ` [PATCH v4 03/13] libata: migrate ACPI code over to new bindings Lin Ming
2012-05-28 5:08 ` [PATCH v4 04/13] libata: use correct PCI devices Lin Ming
2012-05-29 12:22 ` Sergei Shtylyov
2012-05-28 5:08 ` [PATCH v4 05/13] libata-acpi: set acpi state for SATA port Lin Ming
2012-05-28 5:08 ` [PATCH v4 06/13] libata-acpi: add ata port runtime D3Cold support Lin Ming
2012-05-28 5:08 ` [PATCH v4 07/13] libata-acpi: register/unregister device to/from power resource Lin Ming
2012-05-28 5:08 ` [PATCH v4 08/13] libata: detect Device Attention support Lin Ming
2012-05-28 5:08 ` [PATCH v4 09/13] libata: tell scsi layer device supports runtime power off Lin Ming
2012-05-28 5:08 ` [PATCH v4 10/13] [SCSI] pm: resume device if suspend failed Lin Ming
2012-05-28 5:08 ` [PATCH v4 11/13] [SCSI] sr: check support for device busy class events Lin Ming
2012-05-28 5:08 ` [PATCH v4 12/13] [SCSI] sr: support zero power ODD Lin Ming
2012-05-28 5:08 ` [PATCH v4 13/13] [SCSI] sr: make sure ODD is in resumed state in block ioctl Lin Ming
2012-05-28 9:44 ` [PATCH v4 0/13] SATA ZPODD support Alan Cox
2012-05-28 9:54 ` Alan Cox
2012-05-29 12:32 ` Lin Ming
2012-05-30 5:43 ` Aaron Lu
2012-05-30 5:43 ` Aaron Lu
2012-05-30 9:06 ` Fuzhou Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC4C069.1000906@mvista.com \
--to=sshtylyov@mvista.com \
--cc=David.Woodhouse@intel.com \
--cc=aaron.lu@amd.com \
--cc=holger@homac.de \
--cc=jgarzik@pobox.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mjg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.