From: Avi Kivity <avi@redhat.com>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
LKML <linux-kernel@vger.kernel.org>, KVM <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: MMU: fix huge page adapted on non-PAE host
Date: Tue, 29 May 2012 17:23:34 +0300 [thread overview]
Message-ID: <4FC4DBE6.1040703@redhat.com> (raw)
In-Reply-To: <20120528144439.GH4016@redhat.com>
On 05/28/2012 05:44 PM, Andrea Arcangeli wrote:
> On Mon, May 28, 2012 at 05:40:08PM +0300, Avi Kivity wrote:
>> Yes, I see it now. Adjusting mask is incorrect since we won't have the
>> same adjustment on release. I'll apply the patch for 3.5.
>
> Sounds great to me. One thing I'm not sure about is about the real need of
> the mmio check vs a stright get_page (we shouldn't ever get to a gup-fast
> succeeding if this was a mmio region?) but I don't see chances that it
> could hurt either.
This is a device assignment mmio region. gpu_fast() can succeed is we
happen to have a struct page for it (pci hole) or fail if we don't
(64-bit BAR). See hva_to_pfn() (and indeed this is the reason we use
pfns instead of struct pages).
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2012-05-29 14:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-28 6:10 [PATCH] KVM: MMU: fix huge page adapted on non-PAE host Xiao Guangrong
2012-05-28 10:57 ` Avi Kivity
2012-05-28 11:39 ` Xiao Guangrong
2012-05-28 12:24 ` Avi Kivity
2012-05-28 12:56 ` Xiao Guangrong
2012-05-28 13:14 ` Avi Kivity
2012-05-28 13:41 ` Xiao Guangrong
2012-05-28 13:53 ` Avi Kivity
2012-05-28 14:05 ` Xiao Guangrong
2012-05-28 14:20 ` Avi Kivity
2012-05-28 14:42 ` Andrea Arcangeli
2012-05-28 14:32 ` Andrea Arcangeli
2012-05-28 14:40 ` Avi Kivity
2012-05-28 14:44 ` Andrea Arcangeli
2012-05-29 14:23 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC4DBE6.1040703@redhat.com \
--to=avi@redhat.com \
--cc=aarcange@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.