From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glauber Costa Subject: Re: [PATCH v3 05/28] memcg: Reclaim when more than one page needed. Date: Tue, 29 May 2012 19:45:42 +0400 Message-ID: <4FC4EF26.30609@parallels.com> References: <1337951028-3427-1-git-send-email-glommer@parallels.com> <1337951028-3427-6-git-send-email-glommer@parallels.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Christoph Lameter Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org, Tejun Heo , Li Zefan , Greg Thelen , Suleiman Souhlal , Michal Hocko , Johannes Weiner , devel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, David Rientjes On 05/29/2012 06:20 PM, Christoph Lameter wrote: > On Tue, 29 May 2012, Christoph Lameter wrote: > >>> * unlikely to succeed so close to the limit, and we fall back >>> * to regular pages anyway in case of failure. >>> */ >>> - if (nr_pages == 1&& ret) >>> + if (nr_pages<= (PAGE_SIZE<< PAGE_ALLOC_COSTLY_ORDER)&& ret) { > > Should this not be > > nr_pages<= 1<< PAGE_ALLOC_COSTLY_ORDER I myself believe you are right. Not sure if Suleiman had anything in mind that we're not seeing when he wrote this code? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx117.postini.com [74.125.245.117]) by kanga.kvack.org (Postfix) with SMTP id 245996B0069 for ; Tue, 29 May 2012 11:48:02 -0400 (EDT) Message-ID: <4FC4EF26.30609@parallels.com> Date: Tue, 29 May 2012 19:45:42 +0400 From: Glauber Costa MIME-Version: 1.0 Subject: Re: [PATCH v3 05/28] memcg: Reclaim when more than one page needed. References: <1337951028-3427-1-git-send-email-glommer@parallels.com> <1337951028-3427-6-git-send-email-glommer@parallels.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Christoph Lameter Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, kamezawa.hiroyu@jp.fujitsu.com, Tejun Heo , Li Zefan , Greg Thelen , Suleiman Souhlal , Michal Hocko , Johannes Weiner , devel@openvz.org, David Rientjes On 05/29/2012 06:20 PM, Christoph Lameter wrote: > On Tue, 29 May 2012, Christoph Lameter wrote: > >>> * unlikely to succeed so close to the limit, and we fall back >>> * to regular pages anyway in case of failure. >>> */ >>> - if (nr_pages == 1&& ret) >>> + if (nr_pages<= (PAGE_SIZE<< PAGE_ALLOC_COSTLY_ORDER)&& ret) { > > Should this not be > > nr_pages<= 1<< PAGE_ALLOC_COSTLY_ORDER I myself believe you are right. Not sure if Suleiman had anything in mind that we're not seeing when he wrote this code? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754094Ab2E2Pr7 (ORCPT ); Tue, 29 May 2012 11:47:59 -0400 Received: from mx2.parallels.com ([64.131.90.16]:57274 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753363Ab2E2Pr6 (ORCPT ); Tue, 29 May 2012 11:47:58 -0400 Message-ID: <4FC4EF26.30609@parallels.com> Date: Tue, 29 May 2012 19:45:42 +0400 From: Glauber Costa User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 MIME-Version: 1.0 To: Christoph Lameter CC: , , , , Tejun Heo , Li Zefan , Greg Thelen , Suleiman Souhlal , Michal Hocko , Johannes Weiner , , David Rientjes Subject: Re: [PATCH v3 05/28] memcg: Reclaim when more than one page needed. References: <1337951028-3427-1-git-send-email-glommer@parallels.com> <1337951028-3427-6-git-send-email-glommer@parallels.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [188.255.67.70] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/29/2012 06:20 PM, Christoph Lameter wrote: > On Tue, 29 May 2012, Christoph Lameter wrote: > >>> * unlikely to succeed so close to the limit, and we fall back >>> * to regular pages anyway in case of failure. >>> */ >>> - if (nr_pages == 1&& ret) >>> + if (nr_pages<= (PAGE_SIZE<< PAGE_ALLOC_COSTLY_ORDER)&& ret) { > > Should this not be > > nr_pages<= 1<< PAGE_ALLOC_COSTLY_ORDER I myself believe you are right. Not sure if Suleiman had anything in mind that we're not seeing when he wrote this code?