From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: Boris Ranto <branto@redhat.com>, xfs <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests 016: Do not discard blocks at the mkfs time, more verbose version
Date: Tue, 29 May 2012 11:54:31 -0500 [thread overview]
Message-ID: <4FC4FF47.50606@sandeen.net> (raw)
In-Reply-To: <20111028095354.GA1062@infradead.org>
On 10/28/11 4:53 AM, Christoph Hellwig wrote:
> On Fri, Oct 28, 2011 at 05:38:06AM -0400, Boris Ranto wrote:
>> The test 016 fills scratch device with some data and then creates xfs fs
>> on the scratch device. Later, the test assumes that the previously
>> written data are still written there and checks for them at specific
>> locations. On ssd drive this will lead to a failure since the blocks are
>> discarded by default when the mkfs command is run.
>> This is a more verbose version of the previous patch.
>> This simple patch that adds -K to stop the discarding (if the mkfs
>> command supports it) fixed the issue for me:
>>
>> Signed-off-by: Boris Ranto <branto@redhat.com>
>
> Looks good,
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Seems this one got lost; we should still merge it, yes?
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-05-29 16:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-26 10:46 [PATCH] xfstests 016: Do not discard blocks at the mkfs time Boris Ranto
2011-10-27 16:04 ` Christoph Hellwig
2011-10-28 9:25 ` Boris Ranto
2011-10-28 9:38 ` [PATCH] xfstests 016: Do not discard blocks at the mkfs time, more verbose version Boris Ranto
2011-10-28 9:53 ` Christoph Hellwig
2012-05-29 16:54 ` Eric Sandeen [this message]
2012-05-30 7:42 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC4FF47.50606@sandeen.net \
--to=sandeen@sandeen.net \
--cc=branto@redhat.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.