From: Jens Lehmann <Jens.Lehmann@web.de>
To: Jon Seymour <jon.seymour@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com, phil.hord@gmail.com,
Ramsay Jones <ramsay@ramsay1.demon.co.uk>,
Johannes Sixt <j6t@kdbg.org>
Subject: Re: [PATCH v7 0/9] submodule: improve robustness of path handling
Date: Tue, 29 May 2012 21:21:18 +0200 [thread overview]
Message-ID: <4FC521AE.1010707@web.de> (raw)
In-Reply-To: <CAH3AnroT1vs-s==ykNyogq6gbVncY0pt5U1=fMp+b6B0jwG19Q@mail.gmail.com>
Am 29.05.2012 00:01, schrieb Jon Seymour:
> On Tue, May 29, 2012 at 6:07 AM, Jens Lehmann <Jens.Lehmann@web.de> wrote:
>> So I'd vote for just fixing the relative submodule path issues and to
>> not care about the possible issues with URLs. Opinions?
>
> I'll write a minimal patch to solve my relative path problem without
> fixing the invalid/"greedy" submodule url or url normalization issues.
I'd really appreciate that.
> Do you have any comments about whether the failures documented in 2/9
> and 4/9 are worth noting, at least, as weaknesses?
Sure, they document known problems. Me thinks they all should be
squashed into a single patch and submitted separately. The following
three tests from 2/9 are redundant and can be dropped (they are
already handled by the '../../subrepo' case):
'../../../subrepo fails with URL - ssh://hostname/repo' "
'../../../../subrepo fails with with URL - ssh://hostname/repo' "
'../../../../../subrepo fails with URL - ssh://hostname/repo' "
>> (And patches 6-8 contain changes to test cases other than just changing
>> test_expect_failure to test_expect_success which makes reviewing this
>> series unnecessarily hard)
>
> Agree absolutely about patch 8 - I will re-roll with separate tests to
> document the test setup issue I fixed in 8.
>
> The only other changes to tests in 6 and 7 were the removal of
> comments about the actual bad behaviour. Would your preference be that
> I removed these #actual comments completely or that I moved
> documentation of the actual behaviour to the header of the test?
I'd prefer just to see the failure => success changes, so the comments
look superfluous to me and should be dropped from the failure case.
prev parent reply other threads:[~2012-05-29 19:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-27 15:34 [PATCH v7 0/9] submodule: improve robustness of path handling Jon Seymour
2012-05-27 15:34 ` [PATCH v7 1/9] submodule: additional regression tests for relative URLs Jon Seymour
2012-05-27 15:34 ` [PATCH v7 2/9] submodule: document failure to detect invalid submodule URLs Jon Seymour
2012-05-27 15:34 ` [PATCH v7 3/9] submodule: document failure to handle relative superproject origin URLs Jon Seymour
2012-05-27 15:34 ` [PATCH v7 4/9] submodule: document failure to handle improperly normalized remote " Jon Seymour
2012-05-27 15:34 ` [PATCH v7 5/9] submodule: extract normalize_path into standalone function Jon Seymour
2012-05-27 15:34 ` [PATCH v7 6/9] submodule: fix detection of invalid submodule URL Jon Seymour
2012-05-28 19:01 ` Johannes Sixt
2012-05-28 21:39 ` Jon Seymour
2012-06-03 9:51 ` Jon Seymour
2012-05-27 15:34 ` [PATCH v7 7/9] submodule: fix sync handling of relative superproject origin URLs Jon Seymour
2012-05-27 15:34 ` [PATCH v7 8/9] submodule: fix handling of denormalized " Jon Seymour
2012-05-27 22:57 ` Jon Seymour
2012-05-27 15:34 ` [PATCH v7 9/9] submodule: fix normalization to handle repeated ./ Jon Seymour
2012-05-28 20:07 ` [PATCH v7 0/9] submodule: improve robustness of path handling Jens Lehmann
2012-05-28 22:01 ` Jon Seymour
2012-05-29 19:21 ` Jens Lehmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC521AE.1010707@web.de \
--to=jens.lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=jon.seymour@gmail.com \
--cc=phil.hord@gmail.com \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.