From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] tegra: usb: fix wrong error check
Date: Tue, 29 May 2012 16:18:09 -0600 [thread overview]
Message-ID: <4FC54B21.30007@wwwdotorg.org> (raw)
In-Reply-To: <1338328033-8597-3-git-send-email-dev@lynxeye.de>
On 05/29/2012 03:47 PM, Lucas Stach wrote:
> Just stumbled upon this, while looking through the usb code. loop_count
> runs down from 10000, so the correct condition to error out is ==0.
The code change is probably fine, but it'd be better if the commit
description stated just what was being changed and why, rather than
being conversational.
Acked-by: Stephen Warren <swarren@wwwdotorg.org>
next prev parent reply other threads:[~2012-05-29 22:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-29 21:47 [U-Boot] [PATCH 1/3] tegra: add a method to query RAM size from hardware Lucas Stach
2012-05-29 21:47 ` [U-Boot] [PATCH 2/3] tegra: add ULPI on USB2 funcmux entry Lucas Stach
2012-05-29 22:16 ` Stephen Warren
2012-05-29 21:47 ` [U-Boot] [PATCH 3/3] tegra: usb: fix wrong error check Lucas Stach
2012-05-29 22:18 ` Stephen Warren [this message]
2012-05-29 23:20 ` Tom Warren
2012-05-29 22:12 ` [U-Boot] [PATCH 1/3] tegra: add a method to query RAM size from hardware Stephen Warren
2012-05-29 23:19 ` Tom Warren
2012-05-29 23:47 ` Stephen Warren
2012-05-30 16:04 ` Tom Warren
2012-05-30 16:37 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC54B21.30007@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.