All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Joe Perches <joe@perches.com>
Cc: <linux-wireless@vger.kernel.org>, <ath6kl-devel@qualcomm.com>,
	Etay Luz <eluz@qca.qualcomm.com>
Subject: Re: [PATCH] ath6kl: support changing dtim period on AP mode
Date: Wed, 30 May 2012 11:15:54 +0300	[thread overview]
Message-ID: <4FC5D73A.9040807@qca.qualcomm.com> (raw)
In-Reply-To: <1338365645.28696.0.camel@joe2Laptop>

On 05/30/2012 11:14 AM, Joe Perches wrote:
> On Wed, 2012-05-30 at 10:43 +0300, Kalle Valo wrote:
>> +	ret = ath6kl_wmi_ap_set_dtim_cmd(ar->wmi, info->dtim_period);
>> +
>> +	/* ignore error, just print a warning and continue normally */
>> +	if (ret)
>> +		ath6kl_warn("Failed to set dtim_period in beacon: %d", ret);
> 
> missing newline termination

Oh yeah, I missed that. Thanks.

I haven't pushed the patch so I'll just amend the fix.

Kalle

  reply	other threads:[~2012-05-30  8:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-30  7:43 [PATCH] ath6kl: support changing dtim period on AP mode Kalle Valo
2012-05-30  7:44 ` Kalle Valo
2012-05-30  8:26   ` Kalle Valo
2012-05-30  8:14 ` Joe Perches
2012-05-30  8:15   ` Kalle Valo [this message]
2012-05-30  8:58     ` [PATCH] ath6kl: Add missing newline terminations Joe Perches
2012-06-11 13:07       ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FC5D73A.9040807@qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath6kl-devel@qualcomm.com \
    --cc=eluz@qca.qualcomm.com \
    --cc=joe@perches.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.