Re: [PATCH 5/4] exofs: Handle error from d_splice_alias()

[Boaz Harrosh <bharrosh@panasas.com>]

On 05/30/2012 01:39 PM, Boaz Harrosh wrote:

> 
> When directory hierarchy is corrupted and contains cycles, d_splice_alias() can
> fail. Handle the failure cleanly.
> 
> Identical/coppied from:
> 	ext2: Handle error from d_splice_alias()
> 	Signed-off-by: Jan Kara <jack@suse.cz>
> 
> [exofs is just yet another copy/paste of ext2 code]
> 
> Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>


Please carry in your tree, since it's dependent on
[patch 1/4]

Thanks
Boaz

> ---
>  fs/exofs/namei.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/exofs/namei.c b/fs/exofs/namei.c
> index fc7161d..82de452 100644
> --- a/fs/exofs/namei.c
> +++ b/fs/exofs/namei.c
> @@ -50,13 +50,19 @@ static struct dentry *exofs_lookup(struct inode *dir, struct dentry *dentry,
>  {
>  	struct inode *inode;
>  	ino_t ino;
> +	struct dentry *ret;
>  
>  	if (dentry->d_name.len > EXOFS_NAME_LEN)
>  		return ERR_PTR(-ENAMETOOLONG);
>  
>  	ino = exofs_inode_by_name(dir, dentry);
>  	inode = ino ? exofs_iget(dir->i_sb, ino) : NULL;
> -	return d_splice_alias(inode, dentry);
> +	ret = d_splice_alias(inode, dentry);
> +	if (IS_ERR(ret)) {
> +		EXOFS_ERR("directory #%lu corrupted", dir->i_ino);
> +		iput(inode);
> +	}
> +	return ret;
>  }
>  
>  static int exofs_create(struct inode *dir, struct dentry *dentry, umode_t mode,