From: Andrzej Kaczmarek <andrzej.kaczmarek@tieto.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Andre Guedes <andre.guedes@openbossa.org>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH v2] Bluetooth: Use hci_conn data to handle failed LE Connection Complete
Date: Wed, 30 May 2012 15:43:38 +0200 [thread overview]
Message-ID: <4FC6240A.3030009@tieto.com> (raw)
In-Reply-To: <1337928909.15105.88.camel@aeonflux>
Hi Marcel,
On 25.05.2012 08:55, Marcel Holtmann wrote:
>> I was taking a look at Core spec change request document [1] and I found this:
>>
>> Erratum 4215, LE connection complete event missing exception
>> "... On failure, for this event, all other parameters are not valid."
>>
>> It clearly states this is an expected behavior and nullify those
>> parameters doesn't make the adapter broken.
>>
>> Thus, in case of failure, we should not rely on those parameters
>> (BD_ADDR included) in order to properly handle LE Connection Complete
>> Events.
>
> if this is so, then we should only do that and strictly enforce only one
> LE connection attempt at a time. Also then there is no need to bother
> with trying to check for the BD_ADDR later.
I created patch which does not allow 2nd outgoing LE connection attempt
and also reworded commit message for this one so it does state
explicitly that we should consider BDADDR from failed LE Connection
Complete as not valid and not use it.
Please take a look at my new patches (3 in total).
BR,
Andrzej
prev parent reply other threads:[~2012-05-30 13:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-16 20:55 [PATCH v2] Bluetooth: Use hci_conn data to handle failed LE Connection Complete Andrzej Kaczmarek
2012-05-16 21:05 ` Marcel Holtmann
2012-05-16 21:44 ` Andrzej Kaczmarek
2012-05-16 21:48 ` Marcel Holtmann
2012-05-17 8:05 ` Andrzej Kaczmarek
2012-05-21 22:30 ` Andre Guedes
2012-05-25 6:55 ` Marcel Holtmann
2012-05-30 13:43 ` Andrzej Kaczmarek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC6240A.3030009@tieto.com \
--to=andrzej.kaczmarek@tieto.com \
--cc=andre.guedes@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.