From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH 4/4] drm: Renesas SH Mobile DRM driver
Date: Wed, 30 May 2012 17:10:00 +0200
Message-ID: <4FC63848.1030709@metafoo.de>
References: <1338381179-13290-1-git-send-email-laurent.pinchart@ideasonboard.com>
	<1338381179-13290-5-git-send-email-laurent.pinchart@ideasonboard.com>
	<4FC63279.10900@metafoo.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from smtp-out-102.synserver.de (smtp-out-102.synserver.de
	[212.40.185.102])
	by gabe.freedesktop.org (Postfix) with ESMTP id 462A4A02B0
	for <dri-devel@lists.freedesktop.org>;
	Wed, 30 May 2012 08:06:50 -0700 (PDT)
In-Reply-To: <4FC63279.10900@metafoo.de>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On 05/30/2012 04:45 PM, Lars-Peter Clausen wrote:
> On 05/30/2012 02:32 PM, Laurent Pinchart wrote:
>> [...]
>> +	for (i =3D 0; i < (format->yuv ? 2 : 1); ++i) {
>> +		obj =3D drm_gem_object_lookup(dev, file_priv,
>> +					    mode_cmd->handles[i]);
>> +		if (obj =3D=3D NULL) {
>> +			dev_dbg(dev->dev, "GEM object %u not found\n",
>> +				mode_cmd->handles[i]);
>> +			ret =3D -ENOENT;
>> +			goto error;
>> +		}
>> +		sfb->sobj[i] =3D to_shmob_gem_object(obj);
>> +	}
>> +
> =

> I added multi-plane support the cma fb helper functions and it seems to
> work. But all other DRM drivers seem to assume that multi-plane formats
> still only have a single buffer, while yours seems to assume that there i=
s a
> plane for each buffer. The exception is the Exynos driver, but it added a
> new set of formats which are identical to the other formats, but use one
> buffer per plane.
> =

> So I'm not sure how to implement this correctly in a generic fashion.
> =


This post by Ville Syrj=E4l=E4 seems to explain it quite well:
http://lists.freedesktop.org/archives/dri-devel/2012-April/021044.html