From: David Daney <david.daney@cavium.com>
To: "Steven J. Hill" <sjhill@mips.com>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
Subject: Re: [PATCH 1/9] MIPS: Add microMIPS breakpoints and DSP support.
Date: Wed, 30 May 2012 10:23:30 -0700 [thread overview]
Message-ID: <4FC65792.1060906@cavium.com> (raw)
In-Reply-To: <1337892366-24210-2-git-send-email-sjhill@mips.com>
On 05/24/2012 01:45 PM, Steven J. Hill wrote:
> From: "Steven J. Hill"<sjhill@mips.com>
>
> Signed-off-by: Steven J. Hill<sjhill@mips.com>
> ---
> arch/mips/include/asm/break.h | 11 +++++++++--
> arch/mips/include/asm/dsp.h | 4 ++++
> arch/mips/kernel/proc.c | 9 +++++++--
> 3 files changed, 20 insertions(+), 4 deletions(-)
>
> diff --git a/arch/mips/include/asm/break.h b/arch/mips/include/asm/break.h
> index 9161e68..4e4dc87 100644
> --- a/arch/mips/include/asm/break.h
> +++ b/arch/mips/include/asm/break.h
> @@ -3,8 +3,9 @@
> * License. See the file "COPYING" in the main directory of this archive
> * for more details.
> *
> - * Copyright (C) 1995, 2003 by Ralf Baechle
> * Copyright (C) 1999 Silicon Graphics, Inc.
> + * Copyright (C) 1995, 2003 by Ralf Baechle
I don't understand the need to rewrite existing copyright messages.
> + * Copyright (C) 2011, 2012 MIPS Technologies, Inc.
> */
> #ifndef __ASM_BREAK_H
> #define __ASM_BREAK_H
> @@ -27,11 +28,17 @@
> #define BRK_STACKOVERFLOW 9 /* For Ada stackchecking */
> #define BRK_NORLD 10 /* No rld found - not used by Linux/MIPS */
> #define _BRK_THREADBP 11 /* For threads, user bp (used by debuggers) */
> +
> +#ifdef CONFIG_CPU_MICROMIPS
> +#define BRK_BUG 12 /* Used by BUG() */
> +#define BRK_KDB 13 /* Used in KDB_ENTER() */
> +#else
> #define BRK_BUG 512 /* Used by BUG() */
> #define BRK_KDB 513 /* Used in KDB_ENTER() */
> +#endif
> +#define MM_BRK_MEMU 14 /* Used by FPU emulator (microMIPS) */
> #define BRK_MEMU 514 /* Used by FPU emulator */
> #define BRK_KPROBE_BP 515 /* Kprobe break */
> #define BRK_KPROBE_SSTEPBP 516 /* Kprobe single step software implementation */
> -#define BRK_MULOVF 1023 /* Multiply overflow */
Why remove BRK_MULOVF? Is it required by microMIPS?
>
> #endif /* __ASM_BREAK_H */
> diff --git a/arch/mips/include/asm/dsp.h b/arch/mips/include/asm/dsp.h
> index e9bfc08..3149b30 100644
> --- a/arch/mips/include/asm/dsp.h
> +++ b/arch/mips/include/asm/dsp.h
> @@ -16,7 +16,11 @@
> #include<asm/mipsregs.h>
>
> #define DSP_DEFAULT 0x00000000
> +#ifdef CONFIG_CPU_MICROMIPS
> +#define DSP_MASK 0x7f
> +#else
> #define DSP_MASK 0x3ff
> +#endif
>
> #define __enable_dsp_hazard() \
> do { \
> diff --git a/arch/mips/kernel/proc.c b/arch/mips/kernel/proc.c
> index 5542817..c5e97d4 100644
> --- a/arch/mips/kernel/proc.c
> +++ b/arch/mips/kernel/proc.c
> @@ -64,14 +64,19 @@ static int show_cpuinfo(struct seq_file *m, void *v)
> cpu_data[n].watch_reg_masks[i]);
> seq_printf(m, "]\n");
> }
> - seq_printf(m, "ASEs implemented\t:%s%s%s%s%s%s\n",
> + seq_printf(m, "ASEs implemented\t:%s%s%s%s%s%s%s\n",
This looks like neither a breakpoint nor DSP related change.
> cpu_has_mips16 ? " mips16" : "",
> cpu_has_mdmx ? " mdmx" : "",
> cpu_has_mips3d ? " mips3d" : "",
> cpu_has_smartmips ? " smartmips" : "",
> cpu_has_dsp ? " dsp" : "",
> - cpu_has_mipsmt ? " mt" : ""
> + cpu_has_mipsmt ? " mt" : "",
> + cpu_has_mmips ? " micromips" : ""
> );
> + if (cpu_has_mmips) {
> + seq_printf(m, "micromips kernel\t: %s\n",
> + (read_c0_config3()& MIPS_CONF3_ISA_OE) ? "yes" : "no");
> + }
> seq_printf(m, "shadow register sets\t: %d\n",
> cpu_data[n].srsets);
> seq_printf(m, "kscratch registers\t: %d\n",
next prev parent reply other threads:[~2012-05-30 17:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 20:45 [PATCH 0/9] Add support for pure microMIPS kernel Steven J. Hill
2012-05-24 20:45 ` [PATCH 1/9] MIPS: Add microMIPS breakpoints and DSP support Steven J. Hill
2012-05-30 17:23 ` David Daney [this message]
2012-05-24 20:45 ` [PATCH 2/9] MIPS: Add support for microMIPS instructions Steven J. Hill
2012-05-30 17:14 ` David Daney
2012-05-24 20:46 ` [PATCH 3/9] MIPS: Add support for microMIPS exception handling Steven J. Hill
2012-05-30 17:33 ` David Daney
2012-05-24 20:46 ` [PATCH 4/9] MIPS: Support microMIPS/MIPS16e handling of delay slots Steven J. Hill
2012-05-24 20:46 ` [PATCH 5/9] MIPS: Support microMIPS/MIPS16e unaligned accesses Steven J. Hill
2012-05-24 20:46 ` [PATCH 6/9] MIPS: Support microMIPS/MIPS16e floating point Steven J. Hill
2012-05-24 20:46 ` [PATCH 7/9] MIPS: Work-around microMIPS GNU assembler bug Steven J. Hill
2012-05-24 20:46 ` [PATCH 8/9] MIPS: Fixup ordering of micro assembler instructions Steven J. Hill
2012-05-24 20:46 ` [PATCH 9/9] MIPS: Add microMIPS configuration option Steven J. Hill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC65792.1060906@cavium.com \
--to=david.daney@cavium.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=sjhill@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.