From: Jonathan Cameron <jic23@kernel.org>
To: Shubhrajyoti D <shubhrajyoti@ti.com>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: ak8975: Make it behave better as modules
Date: Wed, 30 May 2012 20:22:13 +0100 [thread overview]
Message-ID: <4FC67365.4080409@kernel.org> (raw)
In-Reply-To: <1338217921-23174-2-git-send-email-shubhrajyoti@ti.com>
On 05/28/2012 04:12 PM, Shubhrajyoti D wrote:
> The memory regions of the probe and remove are move
> to __devinit and __devexit respectively.
>
> Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
Acked-by: Jonathan Cameron <jic23@kernel.org>
> ---
> dont have hardware. Untested.
Can't see any way this could cause trouble, so fine to merge
anyway...
>
> drivers/staging/iio/magnetometer/ak8975.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/iio/magnetometer/ak8975.c b/drivers/staging/iio/magnetometer/ak8975.c
> index 5834e4a..7562caf 100644
> --- a/drivers/staging/iio/magnetometer/ak8975.c
> +++ b/drivers/staging/iio/magnetometer/ak8975.c
> @@ -471,7 +471,7 @@ static const struct iio_info ak8975_info = {
> .driver_module = THIS_MODULE,
> };
>
> -static int ak8975_probe(struct i2c_client *client,
> +static int __devinit ak8975_probe(struct i2c_client *client,
> const struct i2c_device_id *id)
> {
> struct ak8975_data *data;
> @@ -545,7 +545,7 @@ exit:
> return err;
> }
>
> -static int ak8975_remove(struct i2c_client *client)
> +static int __devexit ak8975_remove(struct i2c_client *client)
> {
> struct iio_dev *indio_dev = i2c_get_clientdata(client);
> struct ak8975_data *data = iio_priv(indio_dev);
next prev parent reply other threads:[~2012-05-30 18:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-28 15:12 [PATCH 1/2] iio: hmc5843: Make it behave better as modules Shubhrajyoti D
2012-05-28 15:12 ` [PATCH 2/2] iio: ak8975: " Shubhrajyoti D
2012-05-30 19:22 ` Jonathan Cameron [this message]
2012-05-30 19:21 ` [PATCH 1/2] iio: hmc5843: " Jonathan Cameron
-- strict thread matches above, loose matches on Subject: below --
2012-06-04 9:41 Shubhrajyoti D
2012-06-04 9:41 ` [PATCH 2/2] iio: ak8975: " Shubhrajyoti D
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC67365.4080409@kernel.org \
--to=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=shubhrajyoti@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.