From mboxrd@z Thu Jan 1 00:00:00 1970 From: KOSAKI Motohiro Subject: Re: [PATCH] meminfo: show /proc/meminfo base on container's memcg Date: Thu, 31 May 2012 03:23:00 -0400 Message-ID: <4FC71C54.3060909@gmail.com> References: <1338260214-21919-1-git-send-email-gaofeng@cn.fujitsu.com> <4FC6B68C.2070703@jp.fujitsu.com> <4FC6BC3E.5010807@jp.fujitsu.com> <4FC6C111.2060108@jp.fujitsu.com> <4FC6D881.4090706@jp.fujitsu.com> <4FC70355.70805@jp.fujitsu.com> <4FC70E5E.1010003@gmail.com> <4FC711A5.4090003@gmail.com> <4FC718BA.8060608@jp.fujitsu.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=yeIa57yU9Q/IKbNa7UUJtyWNhA6x890xU8CBEudJIUQ=; b=aeKD2tHB9yU9lJTRq2f44tsT3mpMta6VD3aYaYmxRHPZDbRuDkryYUntWzmQ/wsvFN tS5n8Rhh96fudAh1ks7U5hG9KZhy5IKVY5/08w/UPpWeIrgQmqCIMhye6PurSvNJ4/N0 X4XKl/CTsAmfqi7ZMP6D6eHDak2BtmYLbk/xTHBoMIqVddfPbR+I99H3NKwU8kL9HOjh iwgA2Y/r9YtByzCPxjCk70qWvAErnwE1UIcwbydekeBEmPGa9yPbaHGLzmEIxKHDsqE7 DbTYptYk5/YcvogIgALef//B8U+uh5VbLpIXcFctczuSnUyAFsz4UBqixgRDxA4nFz1d ICvg== In-Reply-To: <4FC718BA.8060608-+CUm20s59erQFUHtdCDX3A@public.gmane.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Kamezawa Hiroyuki Cc: David Rientjes , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mhocko-AlSwsSmVLrQ@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, KOSAKI Motohiro , akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org (5/31/12 3:07 AM), Kamezawa Hiroyuki wrote: > (2012/05/31 15:37), KOSAKI Motohiro wrote: >> (5/31/12 2:28 AM), David Rientjes wrote: >>> On Thu, 31 May 2012, KOSAKI Motohiro wrote: >>> >>>>> An application should always know the cgroup that its attached to and be >>>>> able to read its state using the command that I gave earlier. >>>> >>>> No. you don't need why userland folks want namespaces. Even though you don't >>>> need namespaces. It doesn't good reason to refuse another use case. >>>> >>> >>> This is tangent to the discussion, we need to revisit why an application >>> other than a daemon managing a set of memcgs would ever need to know the >>> information in /proc/meminfo. No use-case was ever presented in the >>> changelog and its not clear how this is at all relevant. So before >>> changing the kernel, please describe how this actually matters in a real- >>> world scenario. >> >> Huh? Don't you know a meanings of a namespace ISOLATION? isolation mean, >> isolated container shouldn't be able to access global information. If you >> want to lean container/namespace concept, tasting openvz or solaris container >> is a good start. >> >> But anyway, I dislike current implementaion. So, I NAK this patch too. > > Could you give us advice for improving this ? What idea do you have ? ? I'm ok your idea. I only NAKed current Gao's patch. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx195.postini.com [74.125.245.195]) by kanga.kvack.org (Postfix) with SMTP id D659B6B005C for ; Thu, 31 May 2012 03:23:05 -0400 (EDT) Received: by qafl39 with SMTP id l39so641722qaf.9 for ; Thu, 31 May 2012 00:23:05 -0700 (PDT) Message-ID: <4FC71C54.3060909@gmail.com> Date: Thu, 31 May 2012 03:23:00 -0400 From: KOSAKI Motohiro MIME-Version: 1.0 Subject: Re: [PATCH] meminfo: show /proc/meminfo base on container's memcg References: <1338260214-21919-1-git-send-email-gaofeng@cn.fujitsu.com> <4FC6B68C.2070703@jp.fujitsu.com> <4FC6BC3E.5010807@jp.fujitsu.com> <4FC6C111.2060108@jp.fujitsu.com> <4FC6D881.4090706@jp.fujitsu.com> <4FC70355.70805@jp.fujitsu.com> <4FC70E5E.1010003@gmail.com> <4FC711A5.4090003@gmail.com> <4FC718BA.8060608@jp.fujitsu.com> In-Reply-To: <4FC718BA.8060608@jp.fujitsu.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Kamezawa Hiroyuki Cc: KOSAKI Motohiro , David Rientjes , Gao feng , hannes@cmpxchg.org, mhocko@suse.cz, bsingharora@gmail.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, containers@lists.linux-foundation.org (5/31/12 3:07 AM), Kamezawa Hiroyuki wrote: > (2012/05/31 15:37), KOSAKI Motohiro wrote: >> (5/31/12 2:28 AM), David Rientjes wrote: >>> On Thu, 31 May 2012, KOSAKI Motohiro wrote: >>> >>>>> An application should always know the cgroup that its attached to and be >>>>> able to read its state using the command that I gave earlier. >>>> >>>> No. you don't need why userland folks want namespaces. Even though you don't >>>> need namespaces. It doesn't good reason to refuse another use case. >>>> >>> >>> This is tangent to the discussion, we need to revisit why an application >>> other than a daemon managing a set of memcgs would ever need to know the >>> information in /proc/meminfo. No use-case was ever presented in the >>> changelog and its not clear how this is at all relevant. So before >>> changing the kernel, please describe how this actually matters in a real- >>> world scenario. >> >> Huh? Don't you know a meanings of a namespace ISOLATION? isolation mean, >> isolated container shouldn't be able to access global information. If you >> want to lean container/namespace concept, tasting openvz or solaris container >> is a good start. >> >> But anyway, I dislike current implementaion. So, I NAK this patch too. > > Could you give us advice for improving this ? What idea do you have ? ? I'm ok your idea. I only NAKed current Gao's patch. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756567Ab2EaHX7 (ORCPT ); Thu, 31 May 2012 03:23:59 -0400 Received: from mail-qc0-f174.google.com ([209.85.216.174]:61596 "EHLO mail-qc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751323Ab2EaHX5 (ORCPT ); Thu, 31 May 2012 03:23:57 -0400 Message-ID: <4FC71C54.3060909@gmail.com> Date: Thu, 31 May 2012 03:23:00 -0400 From: KOSAKI Motohiro User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Kamezawa Hiroyuki CC: KOSAKI Motohiro , David Rientjes , Gao feng , hannes@cmpxchg.org, mhocko@suse.cz, bsingharora@gmail.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, containers@lists.linux-foundation.org Subject: Re: [PATCH] meminfo: show /proc/meminfo base on container's memcg References: <1338260214-21919-1-git-send-email-gaofeng@cn.fujitsu.com> <4FC6B68C.2070703@jp.fujitsu.com> <4FC6BC3E.5010807@jp.fujitsu.com> <4FC6C111.2060108@jp.fujitsu.com> <4FC6D881.4090706@jp.fujitsu.com> <4FC70355.70805@jp.fujitsu.com> <4FC70E5E.1010003@gmail.com> <4FC711A5.4090003@gmail.com> <4FC718BA.8060608@jp.fujitsu.com> In-Reply-To: <4FC718BA.8060608@jp.fujitsu.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (5/31/12 3:07 AM), Kamezawa Hiroyuki wrote: > (2012/05/31 15:37), KOSAKI Motohiro wrote: >> (5/31/12 2:28 AM), David Rientjes wrote: >>> On Thu, 31 May 2012, KOSAKI Motohiro wrote: >>> >>>>> An application should always know the cgroup that its attached to and be >>>>> able to read its state using the command that I gave earlier. >>>> >>>> No. you don't need why userland folks want namespaces. Even though you don't >>>> need namespaces. It doesn't good reason to refuse another use case. >>>> >>> >>> This is tangent to the discussion, we need to revisit why an application >>> other than a daemon managing a set of memcgs would ever need to know the >>> information in /proc/meminfo. No use-case was ever presented in the >>> changelog and its not clear how this is at all relevant. So before >>> changing the kernel, please describe how this actually matters in a real- >>> world scenario. >> >> Huh? Don't you know a meanings of a namespace ISOLATION? isolation mean, >> isolated container shouldn't be able to access global information. If you >> want to lean container/namespace concept, tasting openvz or solaris container >> is a good start. >> >> But anyway, I dislike current implementaion. So, I NAK this patch too. > > Could you give us advice for improving this ? What idea do you have ? ? I'm ok your idea. I only NAKed current Gao's patch.