From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glauber Costa Subject: Re: [PATCH] meminfo: show /proc/meminfo base on container's memcg Date: Thu, 31 May 2012 12:29:01 +0400 Message-ID: <4FC72BCD.7040403@parallels.com> References: <1338260214-21919-1-git-send-email-gaofeng@cn.fujitsu.com> <4FC6B68C.2070703@jp.fujitsu.com> <4FC6BC3E.5010807@jp.fujitsu.com> <4FC6C111.2060108@jp.fujitsu.com> <4FC6D881.4090706@jp.fujitsu.com> <4FC70355.70805@jp.fujitsu.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Content-Type: text/plain; charset="us-ascii"; format="flowed" To: David Rientjes Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mhocko-AlSwsSmVLrQ@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, KOSAKI Motohiro , akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org On 05/31/2012 10:17 AM, David Rientjes wrote: >> > Hmm....maybe need to mount cgroup in the container (again) and get an access >> > to cgroup >> > hierarchy and find the cgroup it belongs to......if it's allowed. > An application should always know the cgroup that its attached to and be > able to read its state using the command that I gave earlier. I disagree. For simple applications, yes. For full containers, the cgroup in which it lives in is considered part of the external world. It should not have any kind of access to it. Also, tools need to work transparently. That's the same case with /proc/stat, used for top. We can't expect people to recode top to work on containerized environments. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx199.postini.com [74.125.245.199]) by kanga.kvack.org (Postfix) with SMTP id 64D9A6B0070 for ; Thu, 31 May 2012 04:31:23 -0400 (EDT) Message-ID: <4FC72BCD.7040403@parallels.com> Date: Thu, 31 May 2012 12:29:01 +0400 From: Glauber Costa MIME-Version: 1.0 Subject: Re: [PATCH] meminfo: show /proc/meminfo base on container's memcg References: <1338260214-21919-1-git-send-email-gaofeng@cn.fujitsu.com> <4FC6B68C.2070703@jp.fujitsu.com> <4FC6BC3E.5010807@jp.fujitsu.com> <4FC6C111.2060108@jp.fujitsu.com> <4FC6D881.4090706@jp.fujitsu.com> <4FC70355.70805@jp.fujitsu.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: David Rientjes Cc: Kamezawa Hiroyuki , KOSAKI Motohiro , Gao feng , hannes@cmpxchg.org, mhocko@suse.cz, bsingharora@gmail.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, containers@lists.linux-foundation.org On 05/31/2012 10:17 AM, David Rientjes wrote: >> > Hmm....maybe need to mount cgroup in the container (again) and get an access >> > to cgroup >> > hierarchy and find the cgroup it belongs to......if it's allowed. > An application should always know the cgroup that its attached to and be > able to read its state using the command that I gave earlier. I disagree. For simple applications, yes. For full containers, the cgroup in which it lives in is considered part of the external world. It should not have any kind of access to it. Also, tools need to work transparently. That's the same case with /proc/stat, used for top. We can't expect people to recode top to work on containerized environments. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932285Ab2EaIcH (ORCPT ); Thu, 31 May 2012 04:32:07 -0400 Received: from mx2.parallels.com ([64.131.90.16]:43092 "EHLO mx2.parallels.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1758029Ab2EaIcE (ORCPT ); Thu, 31 May 2012 04:32:04 -0400 Message-ID: <4FC72BCD.7040403@parallels.com> Date: Thu, 31 May 2012 12:29:01 +0400 From: Glauber Costa User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: David Rientjes CC: Kamezawa Hiroyuki , KOSAKI Motohiro , Gao feng , , , , , , , , Subject: Re: [PATCH] meminfo: show /proc/meminfo base on container's memcg References: <1338260214-21919-1-git-send-email-gaofeng@cn.fujitsu.com> <4FC6B68C.2070703@jp.fujitsu.com> <4FC6BC3E.5010807@jp.fujitsu.com> <4FC6C111.2060108@jp.fujitsu.com> <4FC6D881.4090706@jp.fujitsu.com> <4FC70355.70805@jp.fujitsu.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/31/2012 10:17 AM, David Rientjes wrote: >> > Hmm....maybe need to mount cgroup in the container (again) and get an access >> > to cgroup >> > hierarchy and find the cgroup it belongs to......if it's allowed. > An application should always know the cgroup that its attached to and be > able to read its state using the command that I gave earlier. I disagree. For simple applications, yes. For full containers, the cgroup in which it lives in is considered part of the external world. It should not have any kind of access to it. Also, tools need to work transparently. That's the same case with /proc/stat, used for top. We can't expect people to recode top to work on containerized environments.