From: Christer Weinigel <christer@weinigel.se>
To: The development of GNU GRUB <grub-devel@gnu.org>
Cc: "Aleš Nesrsta" <starous@volny.cz>
Subject: EHCI: don't stop after finding the first controller
Date: Thu, 31 May 2012 10:46:11 +0200 [thread overview]
Message-ID: <4FC72FD3.2030203@weinigel.se> (raw)
Hi,
Modern Intel chipsets have multiple EHCI controllers but the EHCI code
will only detect the first one. I noticed this because on a test
laptop all external USB ports are connected to the second EHCI
controller so none of them would show up in grub.
The reason is that the PCI code will stop if the PCI iterator function
returns a nonzero value. Change the return value to zero on success so
that the PCI iterator continues with the next controller.
diff --git a/grub-core/bus/usb/ehci.c b/grub-core/bus/usb/ehci.c
index d8ecf26..240c0d5 100644
--- a/grub-core/bus/usb/ehci.c
+++ b/grub-core/bus/usb/ehci.c
@@ -839,7 +839,7 @@ grub_ehci_pci_iter (grub_pci_device_t dev,
grub_dprintf ("ehci", "EHCI grub_ehci_pci_iter: CONFIG_FLAG: %08x\n",
grub_ehci_oper_read32 (e, GRUB_EHCI_CONFIG_FLAG));
- return 1;
+ return 0;
fail:
if (e)
next reply other threads:[~2012-05-31 8:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 8:46 Christer Weinigel [this message]
2012-05-31 9:44 ` EHCI: don't stop after finding the first controller Vladimir 'φ-coder/phcoder' Serbinenko
2012-05-31 11:32 ` Christer Weinigel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC72FD3.2030203@weinigel.se \
--to=christer@weinigel.se \
--cc=grub-devel@gnu.org \
--cc=starous@volny.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.