From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Sa1vs-0004jf-6y for mharc-grub-devel@gnu.org; Thu, 31 May 2012 05:44:40 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48158) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sa1vl-0004iy-6O for grub-devel@gnu.org; Thu, 31 May 2012 05:44:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sa1vf-0001Kz-04 for grub-devel@gnu.org; Thu, 31 May 2012 05:44:32 -0400 Received: from mail-we0-f169.google.com ([74.125.82.169]:55340) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sa1ve-0001Kl-Ni for grub-devel@gnu.org; Thu, 31 May 2012 05:44:26 -0400 Received: by wefh52 with SMTP id h52so605238wef.0 for ; Thu, 31 May 2012 02:44:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; bh=dmcxRgPMP7NiDW+veDd3iP6hRNV+CTCtZziJvSB7ifI=; b=xqn0K4Yi+a93RW7hQYDsfYFikgAbjuvFienxBUzGqxh3feC9SLvj+OqUTWMgScJ9XL Hjhlf4/3+cyHcB6Gvp+miy5YknFPQUcgBAsAp6qEB7Jy51P9wYBu/l7vuTT5HxvhT+9v kSfBiydEgkgTeO9TysDMWe25O4IdZbpaHJw1ysLCxvdRkp3oUBpGQuOVTYBIbIR0GiYD FqFI1udapY1tS8tBQofMtCmLyS52UJBJtoqO7uolMnwHZ6RKUHqALbnjZqR5LQPGtRKF O+fiXqNA4xsGvujOQrIFLbtHcX0f01JU7Je8OjbpTWyfuspUI+qRCebAqLlJh/8hjL9P RoZg== Received: by 10.216.220.81 with SMTP id n59mr13405081wep.220.1338457464120; Thu, 31 May 2012 02:44:24 -0700 (PDT) Received: from debian.x201.phnet (59-232.197-178.cust.bluewin.ch. [178.197.232.59]) by mx.google.com with ESMTPS id i10sm4696397wiy.10.2012.05.31.02.44.22 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 31 May 2012 02:44:23 -0700 (PDT) Message-ID: <4FC73D6A.6000408@gmail.com> Date: Thu, 31 May 2012 11:44:10 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.4) Gecko/20120510 Icedove/10.0.4 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: EHCI: don't stop after finding the first controller References: <4FC72FD3.2030203@weinigel.se> In-Reply-To: <4FC72FD3.2030203@weinigel.se> X-Enigmail-Version: 1.4.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigDE850CBD6493D71367231189" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 74.125.82.169 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 May 2012 09:44:39 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigDE850CBD6493D71367231189 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Please update to latest bzr. Something similar was applied quite some time ago. On 31.05.2012 10:46, Christer Weinigel wrote: > Hi, >=20 > Modern Intel chipsets have multiple EHCI controllers but the EHCI code > will only detect the first one. I noticed this because on a test > laptop all external USB ports are connected to the second EHCI > controller so none of them would show up in grub. >=20 > The reason is that the PCI code will stop if the PCI iterator function > returns a nonzero value. Change the return value to zero on success so= > that the PCI iterator continues with the next controller. >=20 > diff --git a/grub-core/bus/usb/ehci.c b/grub-core/bus/usb/ehci.c > index d8ecf26..240c0d5 100644 > --- a/grub-core/bus/usb/ehci.c > +++ b/grub-core/bus/usb/ehci.c > @@ -839,7 +839,7 @@ grub_ehci_pci_iter (grub_pci_device_t dev, > grub_dprintf ("ehci", "EHCI grub_ehci_pci_iter: CONFIG_FLAG: %08x\n"= , > grub_ehci_oper_read32 (e, GRUB_EHCI_CONFIG_FLAG)); >=20 > - return 1; > + return 0; >=20 > fail: > if (e) >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >=20 --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enigDE850CBD6493D71367231189 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAk/HPXEACgkQNak7dOguQgn1iAEArmfCZ6yLF+fSi4wN8fpEfRiP U2KTbUyEiW1kb7zceE0A/RMIwiyaBTNuWZYTwLSWeiTliYFCrsPQAC1XfLWZvKrS =pXeg -----END PGP SIGNATURE----- --------------enigDE850CBD6493D71367231189--