All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: Matteo Facchinetti <matteo.facchinetti@sirius-es.it>
Cc: linux-mtd@lists.infradead.org
Subject: Re: mtd nand erase and bad block
Date: Thu, 31 May 2012 16:28:12 +0300	[thread overview]
Message-ID: <4FC771EC.4090500@intel.com> (raw)
In-Reply-To: <4FC76039.6020701@sirius-es.it>

On 31/05/12 15:12, Matteo Facchinetti wrote:
> Hi,
> 
> I'm developing a mtd driver for a nand flash controller and I need help;
> I'm to the end of the work, and I have problems and dubts about bad block
> handling.
> 
> For test, I mark manually bad block byte on flash block.
> When I erase with flash_erase, all works and skip the bad block:
> :~# flash_erase /dev/mtd6 0 0
> Erasing 1024 Kibyte @ 100000 --  2 % complete flash_erase: Skipping bad
> block at 00200000
> Erasing 1024 Kibyte @ 2700000 -- 100 % complete
> 
> If I try to erase with -N parameter I read the following output:
> ~# flash_erase -N /dev/mtd6 0 0
> Erasing 1024 Kibnand_erase_nand: attempt to erase a bad block at page
> 0x00001600
> yte @ 200000 --  5 % complete libmtd: error!: MEMERASE64 ioctl failed for
> eraseblock 2 (mtd6)
>         error 5 (Input/output error)
> flash_erase: error!: /dev/mtd6: MTD Erase failure
>              error 5 (Input/output error)
> Erasing 1024 Kibyte @ 2700000 -- 100 % complete
> 
> I espected that with -N option, flash_erase should erase the hand-damaged
> block, recovering the usability of the block. Is it true?
> 
> What's going wrong?

The NAND driver has validation to prevent erasure of bad blocks.  Refer
nand_erase_nand() in drivers/mtd/nand/nand_base

		/* Check if we have a bad block, we do not erase bad blocks! */
		if (nand_block_checkbad(mtd, ((loff_t) page) <<
					chip->page_shift, 0, allowbbt)) {
			pr_warn("%s: attempt to erase a bad block at page 0x%08x\n",
				    __func__, page);
			instr->state = MTD_ERASE_FAILED;
			goto erase_exit;
		}

  reply	other threads:[~2012-05-31 13:28 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-31 12:12 mtd nand erase and bad block Matteo Facchinetti
2012-05-31 13:28 ` Adrian Hunter [this message]
2012-05-31 14:28   ` Matteo Facchinetti
2012-05-31 19:57     ` Shmulik Ladkani
2012-06-01  6:24     ` Adrian Hunter
2012-06-01  6:37       ` Ricard Wanderlof
2012-06-01  8:29         ` Angus CLARK
2012-06-01  8:42           ` Artem Bityutskiy
2012-06-01 11:04             ` Shmulik Ladkani
2012-06-01 14:03               ` Angus CLARK
2012-06-01 14:54                 ` Shmulik Ladkani
2012-06-01 15:28                   ` Angus CLARK
2012-06-05 12:17                   ` Artem Bityutskiy
2012-06-14 17:48                     ` Brian Norris
2012-06-14 21:31                       ` Shmulik Ladkani
2012-06-15  6:55                       ` Angus CLARK
2012-06-26 22:10                       ` Tomer Barletz
2012-06-18  9:34                     ` Angus CLARK
2012-06-27  9:54                       ` Artem Bityutskiy
2012-06-27 12:37                         ` Angus CLARK
2012-06-29 10:31                           ` Artem Bityutskiy
2012-07-02  7:14                             ` Angus CLARK
2012-07-03 12:22                               ` Artem Bityutskiy
2012-07-03 15:05                                 ` Angus CLARK
2012-07-16 14:37                                   ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FC771EC.4090500@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=matteo.facchinetti@sirius-es.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.