From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH 01 of 11] libxc: abstract xenctl_cpumap to just xenctl_map Date: Thu, 31 May 2012 15:47:38 +0100 Message-ID: <4FC7848A.8090600@eu.citrix.com> References: <20423.31696.797148.796736@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20423.31696.797148.796736@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: Andre Przywara , Ian Campbell , Stefano Stabellini , Juergen Gross , "xen-devel@lists.xen.org" , Dario Faggioli List-Id: xen-devel@lists.xenproject.org On 31/05/12 15:10, Ian Jackson wrote: > Dario Faggioli writes ("[PATCH 01 of 11] libxc: abstract xenctl_cpumap to just xenctl_map"): >> More specifically: >> 1. replaces xenctl_cpumap with xenctl_map >> 2. provides bitmap_to_xenctl_map and the reverse; >> 3. re-implement cpumask_to_xenctl_map with bitmap_to_xenctl_map >> and the reverse; >> >> Other than #3, no functional changes. Interface only slightly >> afected. > This looks plausible to me but it needs a review from a hypervisor > maintainer too. What exactly are you looking for from a hypervisor maintianer? I was going to say it looks plausible to me but needs a review from a tools maintianer. :-) Acked-by: George Dunlap