Re: [PATCH] Fix pygrub install.

[George Dunlap <george.dunlap@eu.citrix.com>]

On 01/06/12 11:35, Roger Pau Monne wrote:
> Ian Campbell wrote:
>> On Fri, 2012-06-01 at 11:21 +0100, Roger Pau Monne wrote:
>>> George Dunlap wrote:
>>>> On 01/06/12 09:29, Ian Campbell wrote:
>>>>> On Thu, 2012-05-31 at 10:54 +0100, Anthony PERARD wrote:
>>>>>> On Thu, May 31, 2012 at 10:42 AM, George Dunlap
>>>>>> <George.Dunlap@eu.citrix.com>     wrote:
>>>>>>> The strange thing is that there *is* a pygrub in the right place, so
>>>>>>> it appears that thefollowing line ($INSTALL_PYTHON_PROG) is redundant?
>>>>>> It's seems that the right on the script are already set to 755 by the
>>>>>> setup.py, so this $INSTALL_PYTHON_PROG line is probably an extra.
>>>>> What is the conclusion here? Is the original patch correct and/or is
>>>>> there a subsequent additional fix?
>>>> There is a bug (pygrub is installed both in $(DESTDIR)/foo and
>>>> $(DESTDIR)/$(DESTDIR)/foo), and Anthony's first patch (AFAICT) correctly
>>>> fixes the bug (only installed in $(DESTDIR).
>>>>
>>>> I think there is a redundant command in the Makefile as well, where
>>>> pygrub will be copied to $(DESTDIR)/foo twice.  That doesn't cause
>>>> incorrect behavior, but I would probably still consider it a bug.
>>> I get an error when performing an install-tools on NetBSD:
>>>
>>> byte-compiling /usr/xen42/lib/python2.7/site-packages/grub/LiloConf.py
>>> to LiloConf.pyc
>>> running install_scripts
>>> copying build/scripts-2.7/pygrub ->   //usr/xen42/bin
>>> error: //usr/xen42/bin/pygrub: Too many levels of symbolic links
>> OOI what does //usr/xen42/bin/pygrub point to?
> lrwxr-xr-x  1 root  wheel  21 May 25 14:32 //usr/xen42/bin/pygrub ->
> /usr/xen42/bin/pygrub
>
>>> gmake[3]: *** [install] Error 1
>>> gmake[3]: Leaving directory `/root/xen/xen-clean/tools/pygrub'
>>> gmake[2]: *** [subdir-install-pygrub] Error 2
>>> gmake[2]: Leaving directory `/root/xen/xen-clean/tools'
>>> gmake[1]: *** [subdirs-install] Error 2
>>> gmake[1]: Leaving directory `/root/xen/xen-clean/tools'
>>> gmake: *** [install-tools] Error 2
>>>
>>> Which I'm quite sure is caused by this.
>> "this" == this problem or "this" == this patch?
> I haven't tried the patch, I was referring to the current code in the
> repository, so this == this problem.
Ah, but that must be a different problem -- is it perhaps the case that 
in NetBSD $(PRIVATE_BINDIR) and $(BINDIR) are the same?

  -George