Re: [PATCH RESEND] ASoC: Support TI Isabelle Audio driver

[MR Swami Reddy <MR.Swami.Reddy@ti.com>]

Hi Mark,

On Wednesday 30 May 2012 10:10 PM, Mark Brown wrote:
> On Tue, May 29, 2012 at 04:39:46PM +0530, MR.Swami.Reddy@ti.com wrote:
>
>> he below patch is a basic driver code for TI Isabelle audio codec. The
>> functionalities like headset detection, etc., will be included incrementally
>> in the up-coming patches.
> Overall this is very good, there's a few issues below but they're pretty
> minor and ought to be easy to fix.

Thanks for quick review. I will fix these minor issues and update the patch.
>> +/* codec private data */
>> +struct isabelle_priv {
>> +	struct regmap *regmap;
>> +};
> If this is all you need then you should be able to use the newly
> introduced dev_get_regmap() to get the regmap back (other drivers should
> be being updated for this soon).
>

The dev_get_regmap() is not found in the 'for-next' or '3.5' branch. So
this api can't be used with 'for-next' source base. Please advice. 
>> +static const struct i2c_device_id isabelle_i2c_id[] = {
>> +	{ "isabelle", 0 },
>> +	{ }
>> +};
>> +MODULE_DEVICE_TABLE(i2c, isabelle_i2c_id);
> This should really include a list of part numbers - the general
> expecation people have is that they can just register the part number.
This audio codec has been referred as 'isabelle' in datasheet and no
specific part number.

Thanks
Swami