All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Alain Renaud <arenaud@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstest: Cleanup test permission and gitignore state.
Date: Fri, 01 Jun 2012 09:05:28 -0500	[thread overview]
Message-ID: <4FC8CC28.70805@sandeen.net> (raw)
In-Reply-To: <4FC8C12A.4010805@sgi.com>

On 6/1/12 8:18 AM, Alain Renaud wrote:
> 
> The new test 284/285/286 do not have execute permission set so set
> them. Also test 285 and 286 create 2 executable that are not in .gitignore
> so add then to the list.
> 
> Signed-off-by: Alain Renaud <arenaud@sgi.com>

Looks good to me,

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

I wonder if we can embed something in the ./check script to check executable state and fail if not set - we check things in w/o execute perms all the time and we're constantly having to fix things up.

It's just tidiness really, but a bit of a pain....

-Eric

> diff --git a/.gitignore b/.gitignore
> index 900ff95..c53c0d9 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -88,6 +88,8 @@ src/aio-dio-regress/aio-dio-subblock-eof-read
>  src/aio-dio-regress/aio-free-ring-with-bogus-nr-pages
>  src/aio-dio-regress/aio-io-setup-with-nonwritable-context-pointer
>  src/aio-dio-regress/aiodio_sparse2
> +src/seek_copy_test
> +src/seek_sanity_test
>   dmapi/src/common/cmd/read_invis
>  dmapi/src/common/cmd/set_region
> diff --git a/284 b/284
> old mode 100644
> new mode 100755
> diff --git a/285 b/285
> old mode 100644
> new mode 100755
> diff --git a/286 b/286
> old mode 100644
> new mode 100755
> 
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2012-06-01 14:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-01 13:18 [PATCH] xfstest: Cleanup test permission and gitignore state Alain Renaud
2012-06-01 14:05 ` Eric Sandeen [this message]
2012-06-01 14:17   ` Alain Renaud
2012-06-01 14:21     ` [PATCH] xfstest: Cleanup test permission and gitignore state. V2 Alain Renaud

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FC8CC28.70805@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=arenaud@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.