From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Daney Subject: Re: [PATCH 03/27] smpboot: Define and use cpu_state per-cpu variable in generic code Date: Fri, 01 Jun 2012 09:59:07 -0700 Message-ID: <4FC8F4DB.2070906@gmail.com> References: <20120601090952.31979.24799.stgit@srivatsabhat.in.ibm.com> <20120601091038.31979.67878.stgit@srivatsabhat.in.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120601091038.31979.67878.stgit@srivatsabhat.in.ibm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org To: "Srivatsa S. Bhat" Cc: Venkatesh Pallipadi , Jeremy Fitzhardinge , linux-ia64@vger.kernel.org, linux-mips@linux-mips.org, peterz@infradead.org, linux-kernel@vger.kernel.org, "H. Peter Anvin" , mingo@kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xensource.com, Suresh Siddha , linux-sh@vger.kernel.org, x86@kernel.org, Ingo Molnar , paulmck@linux.vnet.ibm.com, Fenghua Yu , Mike Frysinger , Peter Zijlstra , nikunj@linux.vnet.ibm.com, Konrad Rzeszutek Wilk , rusty@rustcorp.com.au, Chris Metcalf , rjw@sisk.pl, yong.zhang0@gmail.com, tglx@linutronix.de, virtualization@lists.linux-foundation.org, Tony Luck , vatsa@linux.vnet.ibm.com, Ralf Baechle List-Id: linux-arch.vger.kernel.org On 06/01/2012 02:10 AM, Srivatsa S. Bhat wrote: > The per-cpu variable cpu_state is used in x86 and also used in other > architectures, to track the state of the cpu during bringup and hotplug. > Pull it out into generic code. > > Cc: Tony Luck > Cc: Fenghua Yu > Cc: Ralf Baechle > Cc: Benjamin Herrenschmidt > Cc: Paul Mundt > Cc: Chris Metcalf > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: "H. Peter Anvin" > Cc: x86@kernel.org > Cc: Konrad Rzeszutek Wilk > Cc: Jeremy Fitzhardinge > Cc: Peter Zijlstra > Cc: Andrew Morton > Cc: Mike Frysinger > Cc: Yong Zhang > Cc: Venkatesh Pallipadi > Cc: Suresh Siddha > Cc: linux-ia64@vger.kernel.org > Cc: linux-mips@linux-mips.org > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-sh@vger.kernel.org > Cc: xen-devel@lists.xensource.com > Cc: virtualization@lists.linux-foundation.org > Signed-off-by: Srivatsa S. Bhat > --- > > arch/ia64/include/asm/cpu.h | 2 -- > arch/ia64/kernel/process.c | 1 + > arch/ia64/kernel/smpboot.c | 6 +----- > arch/mips/cavium-octeon/smp.c | 4 +--- > arch/powerpc/kernel/smp.c | 6 +----- > arch/sh/include/asm/smp.h | 2 -- > arch/sh/kernel/smp.c | 4 +--- > arch/tile/kernel/smpboot.c | 4 +--- > arch/x86/include/asm/cpu.h | 2 -- > arch/x86/kernel/smpboot.c | 4 +--- > arch/x86/xen/smp.c | 1 + > include/linux/smpboot.h | 1 + > kernel/smpboot.c | 4 ++++ > 13 files changed, 13 insertions(+), 28 deletions(-) > [...] > diff --git a/arch/mips/cavium-octeon/smp.c b/arch/mips/cavium-octeon/smp.c > index 97e7ce9..93cd4b0 100644 > --- a/arch/mips/cavium-octeon/smp.c > +++ b/arch/mips/cavium-octeon/smp.c > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -252,9 +253,6 @@ static void octeon_cpus_done(void) > > #ifdef CONFIG_HOTPLUG_CPU > > -/* State of each CPU. */ > -DEFINE_PER_CPU(int, cpu_state); > - > extern void fixup_irqs(void); > > static DEFINE_SPINLOCK(smp_reserve_lock); The Octeon bit: Acked-by: David Daney FWIW, the rest looks good too. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 01 Jun 2012 18:59:25 +0200 (CEST) Received: from mail-pb0-f49.google.com ([209.85.160.49]:55388 "EHLO mail-pb0-f49.google.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S1903608Ab2FAQ7S (ORCPT ); Fri, 1 Jun 2012 18:59:18 +0200 Received: by pbbrq13 with SMTP id rq13so3532389pbb.36 for ; Fri, 01 Jun 2012 09:59:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=wbLRlIRQ0gm2LiNUXyElqCgrygSzoMO1bWGOWHNTWAU=; b=k11OuMGjCTvzNh7rawnPmS2K5WIql00y9kaZD4WQWJLRXsPGND0H3p3rNDMwzRSM0G ph9Ir6uoyrpm6xkUHhCT8tSlwiqsQO9F9c/MhIsn9sTGqIFXIjjJ53CTARKetscIr19I tbuv0wxHjsSHXrjqd/x6QzNFMMQwZPGNFjQdNNpshZAN+BaWOzG0jDlNXn1Laf9gQuCH 7IyKsU3xnUZB7WQE4QPFCSikauRaFAUU0g5B2CG+JfqZLffQgc+OVi3JozuYa5ljCUcC MglRUGNeeptRwGaVtNHLIJzApwoyVPCKbIJvthFKESUsrh5lLEmRf/E1quc1Fet+D1UQ Nbkg== Received: by 10.68.240.105 with SMTP id vz9mr4905000pbc.119.1338569951304; Fri, 01 Jun 2012 09:59:11 -0700 (PDT) Received: from dd1.caveonetworks.com (64.2.3.195.ptr.us.xo.net. [64.2.3.195]) by mx.google.com with ESMTPS id ua6sm3303728pbc.20.2012.06.01.09.59.08 (version=SSLv3 cipher=OTHER); Fri, 01 Jun 2012 09:59:09 -0700 (PDT) Message-ID: <4FC8F4DB.2070906@gmail.com> Date: Fri, 01 Jun 2012 09:59:07 -0700 From: David Daney User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10 MIME-Version: 1.0 To: "Srivatsa S. Bhat" CC: tglx@linutronix.de, peterz@infradead.org, paulmck@linux.vnet.ibm.com, rusty@rustcorp.com.au, mingo@kernel.org, yong.zhang0@gmail.com, akpm@linux-foundation.org, vatsa@linux.vnet.ibm.com, rjw@sisk.pl, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, nikunj@linux.vnet.ibm.com, Tony Luck , Fenghua Yu , Ralf Baechle , Benjamin Herrenschmidt , Paul Mundt , Chris Metcalf , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Konrad Rzeszutek Wilk , Jeremy Fitzhardinge , Peter Zijlstra , Mike Frysinger , Venkatesh Pallipadi , Suresh Siddha , linux-ia64@vger.kernel.org, linux-mips@linux-mips.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, xen-devel@lists.xensource.com, virtualization@lists.linux-foundation.org Subject: Re: [PATCH 03/27] smpboot: Define and use cpu_state per-cpu variable in generic code References: <20120601090952.31979.24799.stgit@srivatsabhat.in.ibm.com> <20120601091038.31979.67878.stgit@srivatsabhat.in.ibm.com> In-Reply-To: <20120601091038.31979.67878.stgit@srivatsabhat.in.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-archive-position: 33505 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: ddaney.cavm@gmail.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Return-Path: On 06/01/2012 02:10 AM, Srivatsa S. Bhat wrote: > The per-cpu variable cpu_state is used in x86 and also used in other > architectures, to track the state of the cpu during bringup and hotplug. > Pull it out into generic code. > > Cc: Tony Luck > Cc: Fenghua Yu > Cc: Ralf Baechle > Cc: Benjamin Herrenschmidt > Cc: Paul Mundt > Cc: Chris Metcalf > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: "H. Peter Anvin" > Cc: x86@kernel.org > Cc: Konrad Rzeszutek Wilk > Cc: Jeremy Fitzhardinge > Cc: Peter Zijlstra > Cc: Andrew Morton > Cc: Mike Frysinger > Cc: Yong Zhang > Cc: Venkatesh Pallipadi > Cc: Suresh Siddha > Cc: linux-ia64@vger.kernel.org > Cc: linux-mips@linux-mips.org > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-sh@vger.kernel.org > Cc: xen-devel@lists.xensource.com > Cc: virtualization@lists.linux-foundation.org > Signed-off-by: Srivatsa S. Bhat > --- > > arch/ia64/include/asm/cpu.h | 2 -- > arch/ia64/kernel/process.c | 1 + > arch/ia64/kernel/smpboot.c | 6 +----- > arch/mips/cavium-octeon/smp.c | 4 +--- > arch/powerpc/kernel/smp.c | 6 +----- > arch/sh/include/asm/smp.h | 2 -- > arch/sh/kernel/smp.c | 4 +--- > arch/tile/kernel/smpboot.c | 4 +--- > arch/x86/include/asm/cpu.h | 2 -- > arch/x86/kernel/smpboot.c | 4 +--- > arch/x86/xen/smp.c | 1 + > include/linux/smpboot.h | 1 + > kernel/smpboot.c | 4 ++++ > 13 files changed, 13 insertions(+), 28 deletions(-) > [...] > diff --git a/arch/mips/cavium-octeon/smp.c b/arch/mips/cavium-octeon/smp.c > index 97e7ce9..93cd4b0 100644 > --- a/arch/mips/cavium-octeon/smp.c > +++ b/arch/mips/cavium-octeon/smp.c > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -252,9 +253,6 @@ static void octeon_cpus_done(void) > > #ifdef CONFIG_HOTPLUG_CPU > > -/* State of each CPU. */ > -DEFINE_PER_CPU(int, cpu_state); > - > extern void fixup_irqs(void); > > static DEFINE_SPINLOCK(smp_reserve_lock); The Octeon bit: Acked-by: David Daney FWIW, the rest looks good too. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pz0-f51.google.com (mail-pz0-f51.google.com [209.85.210.51]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id C6710B7000 for ; Sat, 2 Jun 2012 02:59:14 +1000 (EST) Received: by dajt11 with SMTP id t11so3465696daj.38 for ; Fri, 01 Jun 2012 09:59:12 -0700 (PDT) Message-ID: <4FC8F4DB.2070906@gmail.com> Date: Fri, 01 Jun 2012 09:59:07 -0700 From: David Daney MIME-Version: 1.0 To: "Srivatsa S. Bhat" Subject: Re: [PATCH 03/27] smpboot: Define and use cpu_state per-cpu variable in generic code References: <20120601090952.31979.24799.stgit@srivatsabhat.in.ibm.com> <20120601091038.31979.67878.stgit@srivatsabhat.in.ibm.com> In-Reply-To: <20120601091038.31979.67878.stgit@srivatsabhat.in.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Cc: Venkatesh Pallipadi , Jeremy Fitzhardinge , linux-ia64@vger.kernel.org, linux-mips@linux-mips.org, peterz@infradead.org, linux-kernel@vger.kernel.org, "H. Peter Anvin" , mingo@kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xensource.com, Suresh Siddha , linux-sh@vger.kernel.org, x86@kernel.org, Ingo Molnar , paulmck@linux.vnet.ibm.com, Fenghua Yu , Mike Frysinger , Peter Zijlstra , nikunj@linux.vnet.ibm.com, Konrad Rzeszutek Wilk , rusty@rustcorp.com.au, Chris Metcalf , rjw@sisk.pl, yong.zhang0@gmail.com, tglx@linutronix.de, virtualization@lists.linux-foundation.org, Tony Luck , vatsa@linux.vnet.ibm.com, Ralf Baechle , Paul Mundt , akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 06/01/2012 02:10 AM, Srivatsa S. Bhat wrote: > The per-cpu variable cpu_state is used in x86 and also used in other > architectures, to track the state of the cpu during bringup and hotplug. > Pull it out into generic code. > > Cc: Tony Luck > Cc: Fenghua Yu > Cc: Ralf Baechle > Cc: Benjamin Herrenschmidt > Cc: Paul Mundt > Cc: Chris Metcalf > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: "H. Peter Anvin" > Cc: x86@kernel.org > Cc: Konrad Rzeszutek Wilk > Cc: Jeremy Fitzhardinge > Cc: Peter Zijlstra > Cc: Andrew Morton > Cc: Mike Frysinger > Cc: Yong Zhang > Cc: Venkatesh Pallipadi > Cc: Suresh Siddha > Cc: linux-ia64@vger.kernel.org > Cc: linux-mips@linux-mips.org > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-sh@vger.kernel.org > Cc: xen-devel@lists.xensource.com > Cc: virtualization@lists.linux-foundation.org > Signed-off-by: Srivatsa S. Bhat > --- > > arch/ia64/include/asm/cpu.h | 2 -- > arch/ia64/kernel/process.c | 1 + > arch/ia64/kernel/smpboot.c | 6 +----- > arch/mips/cavium-octeon/smp.c | 4 +--- > arch/powerpc/kernel/smp.c | 6 +----- > arch/sh/include/asm/smp.h | 2 -- > arch/sh/kernel/smp.c | 4 +--- > arch/tile/kernel/smpboot.c | 4 +--- > arch/x86/include/asm/cpu.h | 2 -- > arch/x86/kernel/smpboot.c | 4 +--- > arch/x86/xen/smp.c | 1 + > include/linux/smpboot.h | 1 + > kernel/smpboot.c | 4 ++++ > 13 files changed, 13 insertions(+), 28 deletions(-) > [...] > diff --git a/arch/mips/cavium-octeon/smp.c b/arch/mips/cavium-octeon/smp.c > index 97e7ce9..93cd4b0 100644 > --- a/arch/mips/cavium-octeon/smp.c > +++ b/arch/mips/cavium-octeon/smp.c > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -252,9 +253,6 @@ static void octeon_cpus_done(void) > > #ifdef CONFIG_HOTPLUG_CPU > > -/* State of each CPU. */ > -DEFINE_PER_CPU(int, cpu_state); > - > extern void fixup_irqs(void); > > static DEFINE_SPINLOCK(smp_reserve_lock); The Octeon bit: Acked-by: David Daney FWIW, the rest looks good too.