From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Elder Subject: Re: [PATCH 07/13] libceph: embed ceph connection structure in mon_client Date: Fri, 01 Jun 2012 12:09:11 -0500 Message-ID: <4FC8F737.7080905@inktank.com> References: <4FC673FC.3060004@inktank.com> <4FC67662.2060005@inktank.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-gg0-f174.google.com ([209.85.161.174]:35583 "EHLO mail-gg0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759269Ab2FARJN (ORCPT ); Fri, 1 Jun 2012 13:09:13 -0400 Received: by gglu4 with SMTP id u4so1943624ggl.19 for ; Fri, 01 Jun 2012 10:09:12 -0700 (PDT) In-Reply-To: Sender: ceph-devel-owner@vger.kernel.org List-ID: To: Sage Weil Cc: ceph-devel@vger.kernel.org On 05/31/2012 11:24 PM, Sage Weil wrote: > Also: when poking around, I noticed that ceph_con_get() and put() are > called directly from osd_client.c... that's a bug! Those connections have > a get and put op defined that twiddles the containing ceph_osd struct's > ref count. So are you saying that the calls in "osd_client.c" to ceph_con_get() and ceph_con_put() should instead be calls to get_osd_con() and put_osd_con(), respectively? (Or more generally con->ops->get() and con->ops->put()?) -Alex