All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Buchner <bilderbuchi@phononoia.at>
To: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
	Clemens Buchacher <drizzd@aon.at>,
	git@vger.kernel.org
Subject: Bug: git ls-files and ignored directories
Date: Sat, 02 Jun 2012 13:00:29 +0200	[thread overview]
Message-ID: <4FC9F24D.7000306@phononoia.at> (raw)
In-Reply-To: <CACsJy8CqMudg=uKuDmRHoYAXhUoYhOp3V2ZLuKM8W5wWWE460w@mail.gmail.com>

@Jeff: Thank you for the clarification. I didn't want to appear pushy, I 
just wanted to make sure that I did everything right and that my mail 
won't get ignored/filtered because of some breach of protocol.

@Junio, Duy: Thanks for starting/proposing work on this!

thanks,
Christoph

On 06/02/2012 12:33 PM, Nguyen Thai Ngoc Duy wrote:
> On Fri, Jun 1, 2012 at 11:03 PM, Junio C Hamano<gitster@pobox.com>  wrote:
>> Jeff King<peff@peff.net>  writes:
>>
>>> No, I don't think anybody is working on it at the moment (at least I
>>> do not see anything near the time of that old discussion, nor do I
>>> recall it being discussed since).
>>>
>>> +cc Clemens, in case he had any work-in-progress as a result that did
>>> not end up getting published.
>> I think the way the codepath for -i feeds path to excluded() is wrong.
>>
>> The excluded() interface relies on the fact that the caller has
>> already checked foo/ before calling it for foo/bar; when asked to
>> see if "foo/bar" is excluded, it does not consider if "foo/" is
>> excluded---the caller should have already checked it.
> Sparse checkout deals with the exact same problem and it reconstructs
> a tree structure from cache list, before feeding to excluded(). I
> thought of generalizing it (e.g. for this case), but with v5 in
> progress, we'll probably have tree-based index soon. "ls-files -i"
> could be fixed by then.

  reply	other threads:[~2012-06-02 11:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-30 10:22 Bug: git ls-files and ignored directories Christoph Buchner
2012-05-31 10:14 ` Christoph Buchner
2012-06-01  9:37   ` Jeff King
2012-06-01 15:30     ` Clemens Buchacher
2012-06-01 16:03     ` Junio C Hamano
2012-06-01 18:28       ` Junio C Hamano
2012-06-01 19:22         ` Junio C Hamano
2012-06-02 10:33       ` Nguyen Thai Ngoc Duy
2012-06-02 11:00         ` Christoph Buchner [this message]
2012-06-02 22:56           ` Junio C Hamano
2012-06-03 11:44             ` Christoph Buchner
2012-06-03 22:24               ` Junio C Hamano
2012-06-04  2:12                 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FC9F24D.7000306@phononoia.at \
    --to=bilderbuchi@phononoia.at \
    --cc=drizzd@aon.at \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=pclouds@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.