Re: [git:v4l-utils/master] Add HW_SEEK and TUNER_BAND capabilities to videodev2.h

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 06/02/2012 02:15 PM, Hans Verkuil wrote:
> On Sat June 2 2012 11:11:53 Hans de Goede wrote:
>> This is an automatic generated email to let you know that the following patch were queued at the
>> http://git.linuxtv.org/v4l-utils.git tree:
>>
>> Subject: Add HW_SEEK and TUNER_BAND capabilities to videodev2.h
>> Author:  Hans de Goede<hdegoede@redhat.com>
>> Date:    Sat Jun 2 11:11:53 2012 +0200
>>
>> Bring in the pending (reviewed and acked) changes from:
>
> But not merged. I think this is a bit too quick. It is good practice to wait
> with making such changes to v4l-utils until Mauro has merged the videodev2.h
> changes as well.

Ok, next time around I'll wait.

> I also have a small request:
>
> +static const char *band_names[] = {
> +       "default",
> +       "fm-eur_us",
> +       "fm-japan",
> +       "fm-russian",
> +       "fm-weather",
> +       "am-mw",
> +};
>
> Can you rename "fm-eur_us" to "fm-eur-us"? That mix of '-' and '_' is very
> jarring and awkward to type IMHO.

Done.

Regards,

Hans