From: Antti Palosaari <crope@iki.fi>
To: linux-media <linux-media@vger.kernel.org>
Subject: Re: Fwd: [Bug 827538] DVB USB device firmware requested in module_init()
Date: Sun, 03 Jun 2012 05:44:44 +0300 [thread overview]
Message-ID: <4FCACF9C.8060509@iki.fi> (raw)
In-Reply-To: <4FCA41D7.2060206@iki.fi>
On 06/02/2012 07:39 PM, Antti Palosaari wrote:
> On 06/01/2012 10:52 PM, Antti Palosaari wrote:
>>
>>
>> -------- Original Message --------
>> Subject: [Bug 827538] DVB USB device firmware requested in module_init()
>> Date: Fri, 01 Jun 2012 19:44:17 +0000
>> From: bugzilla@redhat.com
>> To: crope@iki.fi
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=827538
>>
>> Kay Sievers <kay@redhat.com> changed:
>>
>> What |Removed |Added
>> ----------------------------------------------------------------------------
>>
>>
>> CC| |gansalmon@Gmail.com,
>> | |itamar@ispbrasil.com.br,
>> | |kernel-maint@redhat.com,
>> | |madhu.chinakonda@gmail.com
>> Component|udev |kernel
>> Assignee|udev-maint@redhat.com |kernel-maint@redhat.com
>> Summary|DVB USB device firmware |DVB USB device firmware
>> |downloading takes 30 |requested in module_init()
>> |seconds |
>>
>> --- Comment #1 from Kay Sievers <kay@redhat.com> ---
>> This is very likely a kernel driver issue.
>>
>> Drivers must not load firmware in the module_init() path, or device
>> probe()/bind() path. This creates a deadlock in the event handling.
>>
>> We used to silently try to work around that, but recently started
>> to log this error explicitely.
>>
>> The firmware should in general be requested asynchronously, or at the
>> first
>> open() of the device.
>>
>> Details are here:
>> http://thread.gmane.org/gmane.linux.network/217729
>>
>
> I suspect all of our DVB USB firmere downloading problems are coming
> from that issues. I mean especially those suspend / resume failings too.
>
> What I think I will try to delay driver registertration using workqueue.
> Return just success for the USB driver probe and continue real probe
> from workqueue.
That solves DVB USB firmware loading problems. I wonder why that udev
requirement not to block module init was not informed for linux-media...
Now it is much work to look thru all drivers and check those did not
load firmware on attach or init.
regards
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2012-06-03 2:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-827538-199927-UDXT6TGYkq@bugzilla.redhat.com>
2012-06-01 19:52 ` Fwd: [Bug 827538] DVB USB device firmware requested in module_init() Antti Palosaari
2012-06-02 16:39 ` Antti Palosaari
2012-06-03 2:44 ` Antti Palosaari [this message]
2012-06-03 14:38 ` Brian J. Murrell
2012-06-03 14:43 ` Antti Palosaari
2012-06-03 21:01 ` Antti Palosaari
2012-06-04 13:32 ` Brian J. Murrell
2012-06-04 13:35 ` Devin Heitmueller
2012-06-04 13:54 ` Brian J. Murrell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCACF9C.8060509@iki.fi \
--to=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.