Re: [Qemu-devel] [PATCH] Revert "rtl8139: do the network/host communication only in normal operating mode"

[Jason Wang <jasowang@redhat.com>]

On 06/04/2012 01:48 PM, Anthony Liguori wrote:
> On 05/10/2012 04:37 PM, Jason Wang wrote:
>> This reverts commit ff71f2e8cacefae99179993204172bc65e4303df. This is 
>> because
>> the linux 8139cp driver would leave the card in "Config Register 
>> Write Enable"
>> mode after the eeprom were read or write ( which is unexpected in the 
>> spec
>> ). Also a physical 8139 card can still DMA into host memory in modes 
>> other than
>> Normal mode, so we need revert this commit to align with the behavior of
>> physical card.
>>
>> The issue of 8139cp driver should be fixed in linux seperately.
>>
>> Signed-off-by: Jason Wang<jasowang@redhat.com>
>
> Applied.  Thanks.
>
> Regards,
>
> Anthony Liguori

Hi Anthony:

Michael has some concern on this patch, so I post another patch of 
validating the rx buf instead of checking the opmode, please see 
http://lists.gnu.org/archive/html/qemu-devel/2012-05/msg02385.html. So 
maybe we can apply that or I need to send another patch on top of this 
reverting?

Thanks