From: Jerome Marchand <jmarchan@redhat.com>
To: Joe Perches <joe@perches.com>
Cc: John Moser <john.r.moser@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: Is this code right in zram?
Date: Mon, 04 Jun 2012 14:47:16 +0200 [thread overview]
Message-ID: <4FCCAE54.3010602@redhat.com> (raw)
In-Reply-To: <1338813236.8574.6.camel@joe2Laptop>
On 06/04/2012 02:33 PM, Joe Perches wrote:
> On Mon, 2012-06-04 at 14:08 +0200, Jerome Marchand wrote:
>> It probably doesn't matter much.
>
> Likely true.
>
>> Apparently kcalloc() never got a lot
>> of success and kzalloc(sizeof(foo) * num_foos) type of allocation are
>> more popular.
>
> Likely false, especially in new code.
>
> If you did greps, perhaps you are including the
> k.alloc(sizeof(*foo), GFP)
> forms in your uses multiply counts.
No. Actually I greped it and look quickly at which proportion of those
kzalloc() looked like the above. I have to admit that my sample was
small and certainly not evenly distributed around the source tree.
Jerome
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2012-06-04 12:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 21:43 Is this code right in zram? John Moser
2012-06-01 9:53 ` Borislav Petkov
2012-06-04 12:08 ` Jerome Marchand
2012-06-04 12:33 ` Joe Perches
2012-06-04 12:47 ` Jerome Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCCAE54.3010602@redhat.com \
--to=jmarchan@redhat.com \
--cc=joe@perches.com \
--cc=john.r.moser@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.