From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <4FCCD224.1020307@suse.cz> Date: Mon, 04 Jun 2012 17:20:04 +0200 From: Jiri Slaby MIME-Version: 1.0 References: <1338809738-18967-1-git-send-email-jslaby@suse.cz> <1338809738-18967-14-git-send-email-jslaby@suse.cz> <4FCCA3A6.8080608@nod.at> In-Reply-To: <4FCCA3A6.8080608@nod.at> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Subject: Re: [PATCH 13/24] TTY: um/line, use tty from tty_port To: Richard Weinberger Cc: Jiri Slaby , gregkh@linuxfoundation.org, alan@linux.intel.com, linux-kernel@vger.kernel.org, Jeff Dike , user-mode-linux-devel@lists.sourceforge.net List-ID: On 06/04/2012 02:01 PM, Richard Weinberger wrote: > I have two questions: 1. Are these patches also usable on 3.4 and > 3.3 or do they depend on 3.5's TTY changes? Hi, I don't think they depend on any changes. > 2. Why didn't you use tty_port_open()/close()/etc. as Alan > suggested my in [1]? This was not intended to fix anything particular. If it does, it is a pure coincidence... These patches are a minimalistic subset to ensure every driver has its own tty_port for each tty. We will need this pairing later. So the switch of the driver to the new tty port API, as suggested by Alan, is still needed. I might do that later if I learn how to make UML work. (The conversion is by definition invasive and needs runtime testing.) > [1] > http://lkml.indiana.edu/hypermail/linux/kernel/1201.3/01705.html thanks, -- js suse labs