Re: [PATCH] rbd: Fix ceph_snap_context size calculation

[Alex Elder <elder@dreamhost.com>]

On 06/04/2012 03:11 AM, Yan, Zheng wrote:
> From: "Yan, Zheng"<zheng.z.yan@intel.com>
>
> ceph_snap_context->snaps is an u64 array


You are correct.  We'll get this in soon.  Thanks.

Reviewed-by: Alex Elder <elder@inktank.com>

> Signed-off-by: Zheng Yan<zheng.z.yan@intel.com>
> ---
>   drivers/block/rbd.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index 65665c9..8b9c173 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -499,7 +499,7 @@ static int rbd_header_from_disk(struct rbd_image_header *header,
>   			 / sizeof (*ondisk))
>   		return -EINVAL;
>   	header->snapc = kmalloc(sizeof(struct ceph_snap_context) +
> -				snap_count * sizeof (*ondisk),
> +				snap_count * sizeof(u64),
>   				gfp_flags);
>   	if (!header->snapc)
>   		return -ENOMEM;