From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH resend] Added UBL_MAGIC_PLL number for ublimage + added automatic page size calculation
Date: Mon, 4 Jun 2012 14:29:23 -0700 [thread overview]
Message-ID: <4FCD28B3.4090600@ti.com> (raw)
In-Reply-To: <1338669515-3843-2-git-send-email-stijn.souffriau@essensium.com>
On 06/02/2012 01:38 PM, Stijn Souffriau wrote:
> ---
> tools/mkimage.h | 6 ++++++
> tools/ublimage.c | 29 +++++++++++++++++++++++++++--
> tools/ublimage.h | 2 ++
> 3 files changed, 35 insertions(+), 2 deletions(-)
In addition to what I just said about v2, v3 and so forth (and needing a
body of the commit message, in this case explain what PLL mode is and so
forth), you have a few cases of '//' or:
/* multi line
* comments.
*/
that don't match the required style. Using checkpatch.pl should catch
one or both of these cases.
[snip]
> + {UBL_MAGIC_SAFE,"safe", "Safe boot mode", },
> + {UBL_MAGIC_PLL, "pll", "With PLL enabled to have higher ARM/DMA clocks", },
Missing space. Thanks!
--
Tom
next prev parent reply other threads:[~2012-06-04 21:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-02 20:38 [U-Boot] [PATCH resend] Added watchdog support for davinchi_dm365evm Stijn Souffriau
2012-06-02 20:38 ` [U-Boot] [PATCH resend] Added UBL_MAGIC_PLL number for ublimage + added automatic page size calculation Stijn Souffriau
2012-06-04 21:29 ` Tom Rini [this message]
2012-06-04 21:26 ` [U-Boot] [PATCH resend] Added watchdog support for davinchi_dm365evm Tom Rini
-- strict thread matches above, loose matches on Subject: below --
2012-06-03 9:27 [U-Boot] (no subject) Stijn Souffriau
2012-06-03 9:27 ` [U-Boot] [PATCH resend] Added UBL_MAGIC_PLL number for ublimage + added automatic page size calculation Stijn Souffriau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCD28B3.4090600@ti.com \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.