From: Ricardo Neri <ricardo.neri@ti.com>
To: Xiao Jiang <jgq516@gmail.com>,
"Valkeinen, Tomi" <tomi.valkeinen@ti.com>,
Jarkko Nikula <jarkko.nikula@bitmer.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: Compile err when enable CONFIG_SND_OMAP_SOC_OMAP_HDMI
Date: Mon, 4 Jun 2012 20:24:06 -0500 [thread overview]
Message-ID: <4FCD5FB6.4040806@ti.com> (raw)
In-Reply-To: <4FC6F330.8070408@gmail.com>
Hi Xiao, Tomi, Jarkko,
On 05/30/2012 11:27 PM, Xiao Jiang wrote:
> Ricardo Neri wrote:
>> +Tomi
>>
>> Hi Xiao,
>>
>> On 05/30/2012 02:14 AM, Xiao Jiang wrote:
>>> Hello,
>>>
>>> After enable SND_OMAP_SOC_OMAP_HDMI with omap2plus_defconfig, I got some
>>> err infos with latest
>>> Linus's tree, does somebody also has the same issue?
>>>
>>> sound/soc/omap/omap-hdmi.c:45:24: error: field 'dss_audio' has
>>> incomplete type
>>> sound/soc/omap/omap-hdmi.c: In function 'omap_hdmi_dai_startup':
>>> sound/soc/omap/omap-hdmi.c:67:27: error: 'struct omap_dss_driver' has no
>>> member named 'audio_supported'
>>> sound/soc/omap/omap-hdmi.c: In function 'omap_hdmi_dai_prepare':
>>> sound/soc/omap/omap-hdmi.c:79:29: error: 'struct omap_dss_driver' has no
>>> member named 'audio_enable'
>>> sound/soc/omap/omap-hdmi.c: In function 'omap_hdmi_dai_hw_params':
>>> sound/soc/omap/omap-hdmi.c:208:28: error: 'struct omap_dss_driver' has
>>> no member named 'audio_config'
>>> sound/soc/omap/omap-hdmi.c: In function 'omap_hdmi_dai_trigger':
>>> sound/soc/omap/omap-hdmi.c:224:29: error: 'struct omap_dss_driver' has
>>> no member named 'audio_start'
>>> sound/soc/omap/omap-hdmi.c:229:23: error: 'struct omap_dss_driver' has
>>> no member named 'audio_stop'
>>> sound/soc/omap/omap-hdmi.c: In function 'omap_hdmi_dai_shutdown':
>>> sound/soc/omap/omap-hdmi.c:242:22: error: 'struct omap_dss_driver' has
>>> no member named 'audio_disable'
>>> sound/soc/omap/omap-hdmi.c: In function 'omap_hdmi_dai_prepare':
>>> sound/soc/omap/omap-hdmi.c:80:1: warning: control reaches end of
>>> non-void function
>>
>> Build breaks because there some patches [1] that are still missing in
>> Linus' tree. ASoC HDMI audio driver for OMAP[2] now uses the new DSS
>> audio functionality in [1], but ASoC patches were merged first. DSS
>> patches have been accepted and they are part of Tomi's pull request
>> for DSS for K3.5. Hopefully this will be fixed when v3.5-rc1 is out.
>>
> Ricardo, thanks for your detail infos :).
Just wanted to confirm to you that this build break is not present in
3.5-rc1 as both omapdss and asoc dependencies are present.
Ricardo
>
> Regards,
> Xiao
>> BR,
>>
>> Ricardo
>>
>> [1].http://www.spinics.net/lists/linux-omap/msg69466.html
>> [2].http://www.spinics.net/lists/linux-omap/msg70561.html
>>>
>>> Regards,
>>> Xiao
>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
next prev parent reply other threads:[~2012-06-05 1:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-30 7:14 Compile err when enable CONFIG_SND_OMAP_SOC_OMAP_HDMI Xiao Jiang
2012-05-30 23:35 ` Ricardo Neri
2012-05-31 4:27 ` Xiao Jiang
2012-06-05 1:24 ` Ricardo Neri [this message]
2012-06-05 4:15 ` Xiao Jiang
2012-06-05 15:51 ` Ricardo Neri
2012-06-06 3:01 ` Xiao Jiang
2012-05-31 5:41 ` Jarkko Nikula
2012-05-31 6:31 ` Tomi Valkeinen
2012-05-31 6:42 ` Jarkko Nikula
2012-05-31 7:00 ` Tomi Valkeinen
2012-05-31 8:23 ` Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCD5FB6.4040806@ti.com \
--to=ricardo.neri@ti.com \
--cc=jarkko.nikula@bitmer.com \
--cc=jgq516@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.