From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: do not iterate over all VMs in mmu_shrink() Date: Tue, 05 Jun 2012 17:46:54 +0300 Message-ID: <4FCE1BDE.5030801@redhat.com> References: <20120604115323.GG23670@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, mtosatti@redhat.com To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:49623 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751729Ab2FEOq4 (ORCPT ); Tue, 5 Jun 2012 10:46:56 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q55EkuAr029879 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 5 Jun 2012 10:46:56 -0400 In-Reply-To: <20120604115323.GG23670@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 06/04/2012 02:53 PM, Gleb Natapov wrote: > mmu_shrink() needlessly iterates over all VMs even though it will not > attempt to free mmu pages from more than one on them. Fix that and also > check used mmu pages count outside of VM lock to skip inactive VMs faster. > Applied, thanks. -- error compiling committee.c: too many arguments to function