From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail1.windriver.com ([147.11.146.13]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1Sc75P-0000DV-BC for bitbake-devel@lists.openembedded.org; Wed, 06 Jun 2012 05:39:07 +0200 Received: from ALA-HCA.corp.ad.wrs.com (ala-hca [147.11.189.40]) by mail1.windriver.com (8.14.3/8.14.3) with ESMTP id q563ScL3028055 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Tue, 5 Jun 2012 20:28:38 -0700 (PDT) Received: from [128.224.162.164] (128.224.162.164) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server (TLS) id 14.1.255.0; Tue, 5 Jun 2012 20:28:37 -0700 Message-ID: <4FCECE80.3090604@windriver.com> Date: Wed, 6 Jun 2012 11:29:04 +0800 From: Kang Kai User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 MIME-Version: 1.0 To: Darren Hart References: <3AB6CE7F274E534CAFD089D127A8A1FC23BCA57C@SHSMSX102.ccr.corp.intel.com> <4FCDAF89.8000803@windriver.com> <3AB6CE7F274E534CAFD089D127A8A1FC23BCA684@SHSMSX102.ccr.corp.intel.com> <4FCDC027.5030304@windriver.com> <4FCE40D9.8070107@linux.intel.com> In-Reply-To: <4FCE40D9.8070107@linux.intel.com> X-Originating-IP: [128.224.162.164] X-MIME-Autoconverted: from 8bit to quoted-printable by mail1.windriver.com id q563ScL3028055 Cc: "bitbake-devel@lists.openembedded.org" , "zhenfeng.zhao@windriver.com" Subject: Re: [PATCH 2/2] hob2: create a standalone deploy image tool X-BeenThere: bitbake-devel@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jun 2012 03:39:07 -0000 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable On 2012=E5=B9=B406=E6=9C=8806=E6=97=A5 01:24, Darren Hart wrote: > > On 06/05/2012 01:15 AM, Kang Kai wrote: >> On 2012=E5=B9=B406=E6=9C=8805=E6=97=A5 15:40, Wang, Shane wrote: >>> Kang Kai wrote on 2012-06-05: >>> >>>> On 2012=E5=B9=B406=E6=9C=8805=E6=97=A5 14:42, Wang, Shane wrote: >>>>>> -----Original Message----- >>>>>> From: Kang Kai [mailto:kai.kang@windriver.com] >>>>>> Sent: Tuesday, June 05, 2012 11:37 AM >>>>>> To: dvhart@linux.intel.com >>>>>> Cc: Wang, Shane; zhenfeng.zhao@windriver.com; >>>>>> bitbake-devel@lists.openembedded.org >>>>>> Subject: [PATCH 2/2] hob2: create a standalone deploy image tool >>>>>> >>>>>> diff --git a/bitbake/lib/bb/ui/crumbs/utils.py >>>>>> b/bitbake/lib/bb/ui/crumbs/utils.py >>>>>> index cd01a04..939864f 100644 >>>>>> --- a/bitbake/lib/bb/ui/crumbs/utils.py >>>>>> +++ b/bitbake/lib/bb/ui/crumbs/utils.py >>>>>> @@ -22,6 +22,7 @@ >>>>>> # bitbake which will allow more flexibility. >>>>>> >>>>>> import os >>>>>> +import bb >>>>> Why is this needed? I don't see any change you made in utils.py. >>>>> Is that to say without this line, the functions in utils.py don't w= ork? >>>> Without the import, it just complains that >>>> >>>> NameError: global name 'bb' is not defined >>>> >>>> Regards, >>>> Kai >>> OK, It seems Saul didn't test it when he created utils.py;-) >> I am not quit sure because it is fine when call the deploy image in th= e >> hob. little weird. >> > Probably because another file in the import list includes bb. > > However, this change is not specific to the image tool and should be > broken out as a separate patch. utils.py makes calls to bb.utils.which(= ) > on the third source line, so bb should certainly be imported in utils.p= y. But I import bb in the bitbake-deployimage too. It still complains lack=20 of module bb. Regards, Kai > > -- > Darren > > >> Regards, >> Kai >> >>> -- >>> Shane