All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 5/5] opencv: bump to version 2.4.0
Date: Wed, 06 Jun 2012 07:54:58 +0200	[thread overview]
Message-ID: <4FCEF0B2.7090206@mind.be> (raw)
In-Reply-To: <20120603002007.0c0d01cf@skate>

On 06/03/12 00:20, Thomas Petazzoni wrote:
> Le Sun,  3 Jun 2012 00:09:47 +0200,
> Samuel Martin<s.martin49@gmail.com>  a ?crit :
>
> > +config BR2_PACKAGE_OPENCV_BUILD_opencv_calib3d
> > +    bool "include opencv_calib3d module into the OpenCV build"
> > +    default y
>
> We normally use capital letters for options names. And the _BUILD_ part
> is, IMO, useless. What about simply:
>
> config BR2_PACKAGE_OPENCV_CALIB3D
>
> or
>
> config BR2_PACKAGE_OPENCV_MODULE_CALIB3D
>
> for this specific case?

  And also the menu text should be abbreviated to "calib3d".  The more verbose
text you have now could be used as a help text.  Even better would be to
include some explanation about what the module does in the help text, but
that's a lot more effort of course.

  Regards,
  Arnout
-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

      reply	other threads:[~2012-06-06  5:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-02 22:09 [Buildroot] [PATCH v2 0/5] OpenCV update and x86/x86_64 CPU fetures Samuel Martin
2012-06-02 22:09 ` [Buildroot] [PATCH v2 1/5] target: add symbols for i386/x86_64 cpu features Samuel Martin
2012-06-02 22:17   ` Thomas Petazzoni
2012-06-02 22:09 ` [Buildroot] [PATCH v2 2/5] libevas: refactor *_CONF_OPT assignment with cpu-feature options Samuel Martin
2012-06-02 22:09 ` [Buildroot] [PATCH v2 3/5] sdl_gfx: " Samuel Martin
2012-06-02 22:09 ` [Buildroot] [PATCH v2 4/5] sdl_sound: " Samuel Martin
2012-06-02 22:09 ` [Buildroot] [PATCH v2 5/5] opencv: bump to version 2.4.0 Samuel Martin
2012-06-02 22:20   ` Thomas Petazzoni
2012-06-06  5:54     ` Arnout Vandecappelle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FCEF0B2.7090206@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.