From: Xiao Jiang <jgq516@gmail.com>
To: khilman@ti.com
Cc: vishalm@ti.com, coelho@ti.com,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: About set boot_on for clk32kg regulator
Date: Wed, 06 Jun 2012 18:55:06 +0800 [thread overview]
Message-ID: <4FCF370A.6000508@gmail.com> (raw)
Hi Kevin,
For panda and blaze, wl12xx sdio card can't be found without set on
label in struct omap4_clk32kg_idata,
and after search maillist I found Vishal had posted patch for it.
http://marc.info/?l=linux-omap&m=132017988123957&w=2
But after more investigations, if clk32kg regulator isn't on then sdio
bus can't probe
wl12xx sdio card, which means it isn't possible to enable regulator in
wl12xx driver.
so I set boot_on as true for 32KG regulator as for power reason as follows.
Is it reasonable or not? or is there other solution can fix this issue?
thanks.
diff --git a/arch/arm/mach-omap2/twl-common.c
b/arch/arm/mach-omap2/twl-common.c
index 119d5a9..843bade 100644
--- a/arch/arm/mach-omap2/twl-common.c
+++ b/arch/arm/mach-omap2/twl-common.c
@@ -374,6 +374,7 @@ static struct regulator_init_data omap4_vusb_idata = {
static struct regulator_init_data omap4_clk32kg_idata = {
.constraints = {
.valid_ops_mask = REGULATOR_CHANGE_STATUS,
+ .boot_on = true,
},
};
Regards,
Xiao
reply other threads:[~2012-06-06 10:01 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCF370A.6000508@gmail.com \
--to=jgq516@gmail.com \
--cc=coelho@ti.com \
--cc=khilman@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=vishalm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.