From: Alex Elder <elder@inktank.com>
To: Sage Weil <sage@inktank.com>
Cc: ceph-devel@vger.kernel.org
Subject: Re: [PATCH 3/4] libceph: make ceph_con_revoke() a msg operation
Date: Wed, 06 Jun 2012 06:51:47 -0500 [thread overview]
Message-ID: <4FCF4453.4070802@inktank.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1206052217530.22586@cobra.newdream.net>
On 06/06/2012 12:18 AM, Sage Weil wrote:
> I'm mildly concerned that if the msg isn't on the con the upper layer
> thinks it is it is a bug, and we might be better off keeping this arg and
> asserting that con == msg->con...
The patch I burned myself on over the weekend actually assumed that
the msg->con was available to use by the client code. I.e., it
assumed that it was not reset to NULL whenever the message left
the connection layer.
Making it null like that allows for some run-time verification of
things (e.g., BUG_ON(msg->con == NULL)) but those aren't strictly
necessary, so we could have msg->con hold whatever non-null value
it was last assigned. We could even add a flag to indicate the
notion of who "owns" it if we still wanted the verification.
I'll just keep it as-is unless you have a strong preference for
another option; I'm open.
-Alex
next prev parent reply other threads:[~2012-06-06 11:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 3:24 [PATCH 00/11] continued messenger-related changes Alex Elder
2012-06-06 3:30 ` [PATCH] libceph: osd_client: don't drop reply reference too early Alex Elder
2012-06-06 16:18 ` Sage Weil
2012-06-06 3:30 ` [PATCH] libceph: use con get/put ops from osd_client Alex Elder
2012-06-06 3:30 ` [PATCH 1/2] libceph: embed ceph connection structure in mon_client Alex Elder
2012-06-06 5:22 ` Sage Weil
2012-06-06 16:19 ` Sage Weil
2012-06-06 3:31 ` [PATCH 2/2] libceph: drop connection refcounting for mon_client Alex Elder
2012-06-06 3:31 ` [PATCH 1/2] libceph: init monitor connection when opening Alex Elder
2012-06-06 3:31 ` [PATCH 2/2] libceph: fully initialize connection in con_init() Alex Elder
2012-06-06 3:31 ` [PATCH] libceph: tweak ceph_alloc_msg() Alex Elder
2012-06-06 5:14 ` Sage Weil
2012-06-06 3:31 ` [PATCH 1/4] libceph: have messages point to their connection Alex Elder
2012-06-06 5:16 ` Sage Weil
2012-06-06 3:31 ` [PATCH 2/4] libceph: have messages take a connection reference Alex Elder
2012-06-06 17:06 ` Sage Weil
2012-06-06 17:34 ` Alex Elder
2012-06-06 3:31 ` [PATCH 3/4] libceph: make ceph_con_revoke() a msg operation Alex Elder
2012-06-06 5:18 ` Sage Weil
2012-06-06 11:51 ` Alex Elder [this message]
2012-06-06 3:31 ` [PATCH 4/4] libceph: make ceph_con_revoke_message() a msg op Alex Elder
2012-06-06 5:22 ` Sage Weil
2012-06-06 11:40 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCF4453.4070802@inktank.com \
--to=elder@inktank.com \
--cc=ceph-devel@vger.kernel.org \
--cc=sage@inktank.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.