Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

[Anthony Liguori <anthony@codemonkey.ws>]

On 06/06/2012 08:30 PM, Alon Levy wrote:
> On Wed, Jun 06, 2012 at 08:17:29PM +0800, Anthony Liguori wrote:
>> On 06/06/2012 08:15 PM, Alon Levy wrote:
>>> On Wed, Jun 06, 2012 at 08:08:40PM +0800, Anthony Liguori wrote:
>>>> On 06/06/2012 08:01 PM, Yonit Halperin wrote:
>>>>> On 06/06/2012 12:22 PM, Anthony Liguori wrote:
>>>>>>
>>>>>> So send a QMP event and call it a day.
>>>>>>
>>>>> Using a QMP event is making spice seamless migration dependent on libvirt
>>>>> version.
>>>>
>>>> That is not an acceptable justification.
>>>
>>> To let spice know that libvirt doesn't support the new event would
>>> require libvirt capabilities advertisement to qemu. Is that acceptable?
>>
>> I literally have danpb's event introspection patches from Luiz's PULL
>> request testing on my system right now to be pushed.
> this?: [PATCH 29/29] Add 'query-events' command to QMP to query async events
>
> This is about libvirt getting qemu's event list. I am talking about qemu
> getting libvirt to say "we support event SPICE_MIGRATE_DONE". i.e. Yet
> another capability negotiation, during the handshake QMP phase.

qemu -spice foo,seamless-migration=on

Doesn't seem that hard to me...

Regards,

Anthony Liguori