From: Bart Van Assche <bvanassche@acm.org>
To: Tejun Heo <tj@kernel.org>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
James Bottomley <jbottomley@parallels.com>,
Mike Christie <michaelc@cs.wisc.edu>,
Jun'ichi Nomura <j-nomura@ce.jp.nec.com>,
Stefan Richter <stefanr@s5r6.in-berlin.de>,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH 1/4] block: Fix race on request_queue.end_io invocations
Date: Wed, 06 Jun 2012 12:44:36 +0000 [thread overview]
Message-ID: <4FCF50B4.6000701@acm.org> (raw)
In-Reply-To: <20120605213248.GB3700@mtj.dyndns.org>
On 06/05/12 21:32, Tejun Heo wrote:
> On Tue, Jun 05, 2012 at 05:10:15PM +0000, Bart Van Assche wrote:
>> Some request_queue.end_io implementations can be called safely
>> without the queue lock held while several other implementations
>> assume that the queue lock is held. So let's play it safe and
>> make sure that the queue lock is held around end_io invocations.
>> Found this through source code review.
>>
>> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
>> Cc: Jens Axboe <axboe@kernel.dk>
>> Cc: Tejun Heo <tj@kernel.org>
>> Cc: <stable@kernel.org>
>
> Acked-by: Tejun Heo <tj@kernel.org>
>
> Not sure about stable@ tho. This doesn't fix any visible issue at the
> moment and any change carries some risk.
I don't have a strong opinion about cc-ing stable - leaving out that tag
is fine for me.
Bart.
next prev parent reply other threads:[~2012-06-06 12:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-05 17:08 [PATCH 0/4 v7] Fixes for SCSI device removal Bart Van Assche
2012-06-05 17:10 ` [PATCH 1/4] block: Fix race on request_queue.end_io invocations Bart Van Assche
2012-06-05 21:32 ` Tejun Heo
2012-06-06 12:44 ` Bart Van Assche [this message]
2012-06-06 12:45 ` Jens Axboe
2012-06-06 13:10 ` Bart Van Assche
2012-06-05 17:11 ` [PATCH 2/4] scsi: Fix device removal NULL pointer dereference Bart Van Assche
2012-06-05 17:12 ` [PATCH 3/4] scsi: Change return type of scsi_queue_insert() into void Bart Van Assche
2012-06-05 17:14 ` [PATCH 4/4] scsi: Stop accepting SCSI requests before removing a device Bart Van Assche
2012-06-05 21:36 ` Mike Christie
2012-06-06 12:17 ` Bart Van Assche
2012-06-06 13:29 ` Mike Christie
2012-06-06 14:53 ` Bart Van Assche
2012-06-06 15:21 ` Mike Christie
2012-06-05 22:08 ` Mike Christie
2012-06-06 12:25 ` Bart Van Assche
2012-06-06 13:43 ` Mike Christie
2012-06-06 14:01 ` Mike Christie
2012-06-06 14:12 ` Mike Christie
2012-06-06 15:04 ` Bart Van Assche
2012-06-06 15:28 ` Mike Christie
2012-06-06 16:18 ` Bart Van Assche
2012-06-06 15:07 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCF50B4.6000701@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=j-nomura@ce.jp.nec.com \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=stefanr@s5r6.in-berlin.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.