From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:43992)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1ScNal-0002nN-Ol
	for qemu-devel@nongnu.org; Wed, 06 Jun 2012 17:16:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1ScNak-0007Hi-0H
	for qemu-devel@nongnu.org; Wed, 06 Jun 2012 17:16:35 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:44845)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1ScNaj-0007GX-Q9
	for qemu-devel@nongnu.org; Wed, 06 Jun 2012 17:16:33 -0400
Message-ID: <4FCFC8AC.6020300@weilnetz.de>
Date: Wed, 06 Jun 2012 23:16:28 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <20120224195143.GA16353@vostro.hallyn.com>
	<alpine.DEB.2.02.1206061135350.6030@kaball.uk.xensource.com>
	<4FCF855D.8050208@weilnetz.de> <20120606174936.GA9515@sergelap>
In-Reply-To: <20120606174936.GA9515@sergelap>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [BUG QEMU 1.1] virtio-9p-handle does not compile
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Serge Hallyn <serge.hallyn@canonical.com>
Cc: "aliguori@us.ibm.com" <aliguori@us.ibm.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, aneesh.kumar@linux.vnet.ibm.com

Am 06.06.2012 19:49, schrieb Serge Hallyn:
> Quoting Stefan Weil (sw@weilnetz.de):
>> The patch will fix the compiler error messages, but will the
>> resulting code work? Maybe it has runtime dependencies
>> (Linux kernel?) which should be checked at runtime.
>>
>> Would an enhanced test in configure be a better solution?
>> It could disable VirtFS automatically if the definitions
>> are missing.
>>
>> On Ubuntu Lenny, there is no definition for AT_EMPTY_PATH,
> (Debian Lenny I presume)

Sorry, my mistake. I meant Ubuntu Lucid.

> True, the flag is newer than I thought.  How could the configure option
> be enhanced?  Could we simply grep for it in /usr/include/linux/fcntl.h,
> set an option saying it exists, then still do the #ifndef in
> hw/9pfs/virtio-9p-handle.c?
>
> (The problem is that the glibc and linux headers are currently not
> compatible...  a separate problem, yes, but one I can't currently
> overcome AFAIK)

I'd use virtio-9p-handle only if AT_EMPTY_PATH is defined without
requiring a hack like using linux/fcntl.h.

configure can check that. Should I send a patch which does this check?

Regards,
Stefan W.