All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	Corey Bryant <coreyb@linux.vnet.ibm.com>,
	Richa Marwaha <rmarwah@linux.vnet.ibm.com>,
	qemu-stable@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] use --libexecdir instead of ignoring it first and reinventing it later
Date: Thu, 07 Jun 2012 00:06:46 +0200	[thread overview]
Message-ID: <4FCFD476.6040204@suse.de> (raw)
In-Reply-To: <1339017061-7358-1-git-send-email-mjt@msgid.tls.msk.ru>

Am 06.06.2012 23:11, schrieb Michael Tokarev:
> Commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8 "Add basic version
> of bridge helper" put the bridge helper executable into a fixed
> ${prefix}/libexec/ location, instead of using ${libexecdir} for
> this.  At the same time, --libexecdir is being happily ignored
> by ./configure.  Even more, the same patch sets unused $libexecdir
> variable in the generated config-host.mak, and uses fixed string
> (\${prefix}/libexecdir) for the bridge helper binary.
> 
> Fix this braindamage by introducing $libexecdir variable, using
> it for the bridge helper binary, and recognizing --libexecdir.
> 
> This patch is applicable to stable-1.1.
> 
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> Cc: Corey Bryant <coreyb@linux.vnet.ibm.com>
> Cc: Richa Marwaha <rmarwah@linux.vnet.ibm.com>
> Cc: qemu-stable@nongnu.org

Reviewed-by: Andreas Färber <afaerber@suse.de>

I noticed the lack of this and just passed libexecdir= to make as a
workaround for our openSUSE package.

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

  reply	other threads:[~2012-06-06 22:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-06 21:11 [Qemu-devel] [PATCH] use --libexecdir instead of ignoring it first and reinventing it later Michael Tokarev
2012-06-06 22:06 ` Andreas Färber [this message]
2012-06-06 22:12   ` Michael Tokarev
2012-06-06 22:21     ` Andreas Färber
2012-06-06 22:23       ` Michael Tokarev
2012-06-06 22:36         ` Andreas Färber
2012-06-06 22:50           ` Michael Tokarev
2012-06-06 23:20           ` Bruce Rogers
2012-06-07  4:22           ` Bo Yang
2012-06-07 15:17 ` Corey Bryant
2012-08-16 14:46 ` Andreas Färber
2012-09-03 15:49   ` [Qemu-devel] [PATCH for-1.2] " Andreas Färber
2012-09-10 23:01 ` [Qemu-devel] [PATCH] " Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FCFD476.6040204@suse.de \
    --to=afaerber@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=coreyb@linux.vnet.ibm.com \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=rmarwah@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.