From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48293) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScOSh-00077K-IJ for qemu-devel@nongnu.org; Wed, 06 Jun 2012 18:12:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ScOSf-0001e0-W4 for qemu-devel@nongnu.org; Wed, 06 Jun 2012 18:12:19 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:45080) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScOSf-0001ds-Ow for qemu-devel@nongnu.org; Wed, 06 Jun 2012 18:12:17 -0400 Message-ID: <4FCFD5BE.7040506@msgid.tls.msk.ru> Date: Thu, 07 Jun 2012 02:12:14 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <1339017061-7358-1-git-send-email-mjt@msgid.tls.msk.ru> <4FCFD476.6040204@suse.de> In-Reply-To: <4FCFD476.6040204@suse.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] use --libexecdir instead of ignoring it first and reinventing it later List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: qemu-devel On 07.06.2012 02:06, Andreas F=E4rber wrote: > Am 06.06.2012 23:11, schrieb Michael Tokarev: [] > Reviewed-by: Andreas F=E4rber >=20 > I noticed the lack of this and just passed libexecdir=3D to make as a > workaround for our openSUSE package. Thank you for your review. However, passing libexecdir=3D to make wont work, due to this: >> by ./configure. Even more, the same patch sets unused $libexecdir >> variable in the generated config-host.mak, and uses fixed string >> (\${prefix}/libexecdir) for the bridge helper binary. configure: echo "CONFIG_QEMU_HELPERDIR=3D\"$prefix/libexec\"" >> $config_host_mak You need to pass CONFIG_QEMU_HELPERDIR=3D not libexecdir=3D to make. /mjt