From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Franky Lin" Date: Wed, 06 Jun 2012 23:43:10 +0000 Subject: Re: [PATCH 5/7] drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c: adjust suspicious bit Message-Id: <4FCFEB0E.2020206@broadcom.com> List-Id: References: <1339018901-28439-1-git-send-email-Julia.Lawall@lip6.fr> <1339018901-28439-6-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1339018901-28439-6-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: Brett Rudley , kernel-janitors@vger.kernel.org, Roland Vossen , Arend van Spriel , Kan Yan , "John W. Linville" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, joe@perches.com, Julia Lawall On 06/06/2012 02:41 PM, Julia Lawall wrote: > From: Julia Lawall > > IRQF_TRIGGER_HIGH is 0x00000004, so it seems that& was intended rather than |. > > This problem was found using Coccinelle (http://coccinelle.lip6.fr/). > > Signed-off-by: Julia Lawall Thanks, Julia. But this has already been fixed by Joe Perches [1] and the patch has arrived at Linux wireless tree. Franky [1] https://lkml.org/lkml/2012/5/30/482 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mms3.broadcom.com ([216.31.210.19]:2379 "EHLO MMS3.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753435Ab2FFXnm (ORCPT ); Wed, 6 Jun 2012 19:43:42 -0400 Message-ID: <4FCFEB0E.2020206@broadcom.com> (sfid-20120607_014444_999304_303AB406) Date: Wed, 6 Jun 2012 16:43:10 -0700 From: "Franky Lin" MIME-Version: 1.0 To: "Julia Lawall" cc: "Brett Rudley" , kernel-janitors@vger.kernel.org, "Roland Vossen" , "Arend van Spriel" , "Kan Yan" , "John W. Linville" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, joe@perches.com, "Julia Lawall" Subject: Re: [PATCH 5/7] drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c: adjust suspicious bit operation References: <1339018901-28439-1-git-send-email-Julia.Lawall@lip6.fr> <1339018901-28439-6-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1339018901-28439-6-git-send-email-Julia.Lawall@lip6.fr> Content-Type: text/plain; charset=iso-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 06/06/2012 02:41 PM, Julia Lawall wrote: > From: Julia Lawall > > IRQF_TRIGGER_HIGH is 0x00000004, so it seems that& was intended rather than |. > > This problem was found using Coccinelle (http://coccinelle.lip6.fr/). > > Signed-off-by: Julia Lawall Thanks, Julia. But this has already been fixed by Joe Perches [1] and the patch has arrived at Linux wireless tree. Franky [1] https://lkml.org/lkml/2012/5/30/482 From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Franky Lin" Subject: Re: [PATCH 5/7] drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c: adjust suspicious bit operation Date: Wed, 6 Jun 2012 16:43:10 -0700 Message-ID: <4FCFEB0E.2020206@broadcom.com> References: <1339018901-28439-1-git-send-email-Julia.Lawall@lip6.fr> <1339018901-28439-6-git-send-email-Julia.Lawall@lip6.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Brett Rudley" , kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Roland Vossen" , "Arend van Spriel" , "Kan Yan" , "John W. Linville" , linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org, "Julia Lawall" To: "Julia Lawall" Return-path: In-Reply-To: <1339018901-28439-6-git-send-email-Julia.Lawall-L2FTfq7BK8M@public.gmane.org> Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On 06/06/2012 02:41 PM, Julia Lawall wrote: > From: Julia Lawall > > IRQF_TRIGGER_HIGH is 0x00000004, so it seems that& was intended rather than |. > > This problem was found using Coccinelle (http://coccinelle.lip6.fr/). > > Signed-off-by: Julia Lawall Thanks, Julia. But this has already been fixed by Joe Perches [1] and the patch has arrived at Linux wireless tree. Franky [1] https://lkml.org/lkml/2012/5/30/482 -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html