From: "Bhanu Prakash Gollapudi" <bprakash@broadcom.com>
To: James Bottomley <jbottomley@parallels.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"michaelc@cs.wisc.edu" <michaelc@cs.wisc.edu>
Subject: Re: [PATCH 4/6] bnx2fc: Improve error recovery by handling parity errors
Date: Thu, 7 Jun 2012 01:39:04 -0700 [thread overview]
Message-ID: <4FD068A8.7070305@broadcom.com> (raw)
In-Reply-To: <1339038209.26595.2.camel@dabdike.int.hansenpartnership.com>
On 6/6/2012 8:03 PM, James Bottomley wrote:
> On Mon, 2012-06-04 at 16:15 -0700, Bhanu Prakash Gollapudi wrote:
>> @@ -321,6 +332,9 @@ static void bnx2fc_upload_session(struct fcoe_port *port,
>>
>> del_timer_sync(&tgt->upld_timer);
>>
>> + } else if (test_bit(BNX2FC_FLAG_DISABLE_FAILED,&tgt->flags))
>> + printk(KERN_ERR PFX "ERROR!! DISABLE req failed, destroy"
>> + " not sent to FW\n");
>> } else
>> printk(KERN_ERR PFX "ERROR!! DISABLE req timed out, destroy"
>> " not sent to FW\n");
>
> You didn't actually compile this did you? That else if has to have an
> opening brace to match the closing one on the next else ...
My bad. I fixed this compilation error, but by mistake I applied that
change to next patch. I'll correct it and submit the last three patches
shortly, as you've already picked up the first three.
Thanks,
Bhanu
>
> James
>
> \x13��칻\x1c�&�~�&�\x18��+-��ݶ\x17��w��˛���m�b��lrȢ��^n�r���z�\x1a��h����&��\x1e�G���h�\x03(�階�ݢj"��\x1a�^[m�����z�ޖ���f���h���~�m�
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-06-07 8:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-04 23:15 [PATCH 0/6] bnx2fc version 1.0.12 Bhanu Prakash Gollapudi
2012-06-04 23:15 ` [PATCH 1/6] bnx2fc: use kthread_create_on_node Bhanu Prakash Gollapudi
2012-06-04 23:15 ` [PATCH 2/6] bnx2fc: Reduce object size by consolidating formats Bhanu Prakash Gollapudi
2012-06-04 23:15 ` [PATCH 3/6] bnx2fc: Support interface creation on non-VLAN interface also Bhanu Prakash Gollapudi
2012-06-04 23:15 ` [PATCH 4/6] bnx2fc: Improve error recovery by handling parity errors Bhanu Prakash Gollapudi
2012-06-07 3:03 ` James Bottomley
2012-06-07 8:39 ` Bhanu Prakash Gollapudi [this message]
2012-06-04 23:15 ` [PATCH 5/6] bnx2fc: use list_entry instead of explicit cast Bhanu Prakash Gollapudi
2012-06-04 23:15 ` [PATCH 6/6] bnx2fc: Bumped version to 1.0.12 Bhanu Prakash Gollapudi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD068A8.7070305@broadcom.com \
--to=bprakash@broadcom.com \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.