From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from antcom.de ([188.40.178.216]:60953 "EHLO chuck.antcom.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750877Ab2FGKQM (ORCPT ); Thu, 7 Jun 2012 06:16:12 -0400 Message-ID: <4FD07F69.3040600@antcom.de> Date: Thu, 07 Jun 2012 12:16:09 +0200 From: Roland Stigge MIME-Version: 1.0 To: Peter Meerwald CC: linux-iio@vger.kernel.org Subject: Re: [PATCH 2/2] iio: max517: mark probe() and remove() with __devinit and __devexit References: <1339057907-17381-1-git-send-email-pmeerw@pmeerw.net> <1339057907-17381-2-git-send-email-pmeerw@pmeerw.net> In-Reply-To: <1339057907-17381-2-git-send-email-pmeerw@pmeerw.net> Content-Type: text/plain; charset=UTF-8 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 07/06/12 10:31, Peter Meerwald wrote: > Signed-off-by: Peter Meerwald Acked-by: Roland Stigge > --- > drivers/iio/dac/max517.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/iio/dac/max517.c b/drivers/iio/dac/max517.c > index 352abe2..c3d748c 100644 > --- a/drivers/iio/dac/max517.c > +++ b/drivers/iio/dac/max517.c > @@ -156,7 +156,7 @@ static const struct iio_chan_spec max517_channels[] = { > MAX517_CHANNEL(1) > }; > > -static int max517_probe(struct i2c_client *client, > +static int __devinit max517_probe(struct i2c_client *client, > const struct i2c_device_id *id) > { > struct max517_data *data; > @@ -210,7 +210,7 @@ exit: > return err; > } > > -static int max517_remove(struct i2c_client *client) > +static int __devexit max517_remove(struct i2c_client *client) > { > iio_device_unregister(i2c_get_clientdata(client)); > iio_device_free(i2c_get_clientdata(client)); > @@ -232,7 +232,7 @@ static struct i2c_driver max517_driver = { > .pm = MAX517_PM_OPS, > }, > .probe = max517_probe, > - .remove = max517_remove, > + .remove = __devexit_p(max517_remove), > .id_table = max517_id, > }; > module_i2c_driver(max517_driver);