Re: [Qemu-devel] [PATCH v3 3/4] vl.c: allow for reapeated -sd arguments

["Andreas Färber" <afaerber@suse.de>]

Speaking of typos in the cover letter, "repeated" and...

Am 07.06.2012 07:05, schrieb Peter A. G. Crosthwaite:
> Allows for repeating of -sd arugments in the same way -pflash and -mtdblock

..."arguments".

> can be repeated.
> 
> Signed-off-by: Peter A. G. Crosthwaite <peter.crosthwaite@petalogix.com>

Multiple SD controllers indeed need to be supported, patch looks good.

Andreas

> ---
>  vl.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/vl.c b/vl.c
> index 23ab3a3..a381e90 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2437,7 +2437,7 @@ int main(int argc, char **argv, char **envp)
>                  drive_add(IF_MTD, -1, optarg, MTD_OPTS);
>                  break;
>              case QEMU_OPTION_sd:
> -                drive_add(IF_SD, 0, optarg, SD_OPTS);
> +                drive_add(IF_SD, -1, optarg, SD_OPTS);
>                  break;
>              case QEMU_OPTION_pflash:
>                  drive_add(IF_PFLASH, -1, optarg, PFLASH_OPTS);

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg