From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59648) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Scdtj-0000Vl-DS for qemu-devel@nongnu.org; Thu, 07 Jun 2012 10:41:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Scdta-0001OA-Fc for qemu-devel@nongnu.org; Thu, 07 Jun 2012 10:41:14 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:37812) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Scdta-0001Fh-9e for qemu-devel@nongnu.org; Thu, 07 Jun 2012 10:41:06 -0400 Received: from eusync2.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0M59001IS4T7E450@mailout1.w1.samsung.com> for qemu-devel@nongnu.org; Thu, 07 Jun 2012 15:41:31 +0100 (BST) Received: from [106.109.9.162] by eusync2.samsung.com (Oracle Communications Messaging Server 7u4-23.01(7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0M59001844S94X80@eusync2.samsung.com> for qemu-devel@nongnu.org; Thu, 07 Jun 2012 15:40:59 +0100 (BST) Date: Thu, 07 Jun 2012 18:40:57 +0400 From: Igor Mitsyanko In-reply-to: <4FD09D78.7040209@suse.de> Message-id: <4FD0BD79.8090108@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-15; format=flowed Content-transfer-encoding: QUOTED-PRINTABLE References: <4FD09D78.7040209@suse.de> Subject: Re: [Qemu-devel] [PATCH v3 0/4] Standard SD host controller model List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: Kevin Wolf , peter.maydell@linaro.org, Vincent Palatin , e.voevodin@samsung.com, qemu-devel@nongnu.org, "Peter A. G. Crosthwaite" , kyungmin.park@samsung.com, d.solodkiy@samsung.com, edgar.iglesias@gmail.com, m.kozlov@samsung.com, john.williams@petalogix.com On 06/07/2012 04:24 PM, Andreas F=E4rber wrote: > Am 07.06.2012 07:05, schrieb Peter A. G. Crosthwaite: >> [Original cover by Igor] >> First patch introduces standard SD host controller model. This is = accumulated >> version of my previous patch I sent a while ago and a recent SDHCI= patch by >> Peter A. G. Crosthwaite. >> Second patch introduces Exynos4210-specific SDHCI built on top of = standard SDHCI >> model. >> >> [New] >> Third patch changes the -sd command line argument to be repeatable= , to support multiple SD controllers in one system. >> Fourth patch adds 2x SDHCI controllers to the Xilinx Zynq machine > It's good to see agreement finally being reached here. Looking forw= ard > to testing it on my tegra branch. Vincent's version claimed complia= nce > to version 3.00 while this one says 2.00. What's the delta then, Ig= or? > > http://git.chromium.org/gitweb/?p=3Dchromiumos/third_party/qemu.git= ;a=3Dcommit;h=3D9b9c2ea8bd25be06b23a30f07262ade9190d8e95 Looks like its not actually true, the first thing I noticed is that= =20 documentation defines mandatory 3.00 controller registers Host Contro= l 2=20 and Preset Values, which Vincent's version doesn't implement, I'd say= =20 that his version complies with 2.00 spec. Version sent by Peter=20 implements a wider set of SD host controller features comparing to= =20 Vincen't version. > I'm guessing I at least still need to cherry-pick Vincent's eMMC su= pport > bits on top since hw/sd.c and hw/blockdev.c are unmodified in this = series. > > I'm cc'ing Kevin as block maintainer (PMM is on vacation). I'm hopi= ng > the typos in the commit messages can be fixed when applying to eith= er > branch. > > Regards, > Andreas > >> Changelog: >> Changed from v2: >> corrected typo errors in ADMA1 support >> added patches 3-4 >> v1->v2 >> PATCH1: >> add support for ADMA1 (I havn't tested it though). >> fixed s->prnsts<-> s->pwrcon typo (thanks to Peter, strange th= at it even worked >> before). >> PATCH2: >> change header prefix from "target-arm" to "exynos4210". >> >> Igor Mitsyanko (2): >> hw: introduce standard SD host controller >> exynos4210: introduce Exynos4210 SD host controller model >> >> Peter A. G. Crosthwaite (2): >> vl.c: allow for reapeated -sd arguments >> xilinx_zynq: Added sdhci controllers >> >> Makefile.objs | 1 + >> Makefile.target | 1 + >> default-configs/arm-softmmu.mak | 1 + >> hw/exynos4210.c | 20 + >> hw/exynos4210_sdhci.c | 438 +++++++++++++ >> hw/sdhci.c | 1306 +++++++++++++++++++++++++= ++++++++++++++ >> hw/sdhci.h | 310 +++++++++ >> hw/xilinx_zynq.c | 12 + >> vl.c | 2 +- >> 9 files changed, 2090 insertions(+), 1 deletions(-) >> create mode 100644 hw/exynos4210_sdhci.c >> create mode 100644 hw/sdhci.c >> create mode 100644 hw/sdhci.h >> >