All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Roland Stigge <stigge@antcom.de>
Cc: Peter Meerwald <pmeerw@pmeerw.net>, linux-iio@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: max517: mark probe() and remove() with __devinit and __devexit
Date: Thu, 07 Jun 2012 17:01:14 +0100	[thread overview]
Message-ID: <4FD0D04A.6050504@kernel.org> (raw)
In-Reply-To: <4FD07F69.3040600@antcom.de>

On 06/07/2012 11:16 AM, Roland Stigge wrote:
> On 07/06/12 10:31, Peter Meerwald wrote:
>> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
> 
> Acked-by: Roland Stigge <stigge@antcom.de>
Acked-by: Jonathan Cameron <jic23@kernel.org>

Please send on to Greg KH.

> 
>> ---
>>  drivers/iio/dac/max517.c |    6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/iio/dac/max517.c b/drivers/iio/dac/max517.c
>> index 352abe2..c3d748c 100644
>> --- a/drivers/iio/dac/max517.c
>> +++ b/drivers/iio/dac/max517.c
>> @@ -156,7 +156,7 @@ static const struct iio_chan_spec max517_channels[] = {
>>  	MAX517_CHANNEL(1)
>>  };
>>  
>> -static int max517_probe(struct i2c_client *client,
>> +static int __devinit max517_probe(struct i2c_client *client,
>>  			const struct i2c_device_id *id)
>>  {
>>  	struct max517_data *data;
>> @@ -210,7 +210,7 @@ exit:
>>  	return err;
>>  }
>>  
>> -static int max517_remove(struct i2c_client *client)
>> +static int __devexit max517_remove(struct i2c_client *client)
>>  {
>>  	iio_device_unregister(i2c_get_clientdata(client));
>>  	iio_device_free(i2c_get_clientdata(client));
>> @@ -232,7 +232,7 @@ static struct i2c_driver max517_driver = {
>>  		.pm		= MAX517_PM_OPS,
>>  	},
>>  	.probe		= max517_probe,
>> -	.remove		= max517_remove,
>> +	.remove		=  __devexit_p(max517_remove),
>>  	.id_table	= max517_id,
>>  };
>>  module_i2c_driver(max517_driver);
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


  reply	other threads:[~2012-06-07 15:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-07  8:31 [PATCH 1/2] iio: remove indio_dev pointer from max517_data Peter Meerwald
2012-06-07  8:31 ` [PATCH 2/2] iio: max517: mark probe() and remove() with __devinit and __devexit Peter Meerwald
2012-06-07 10:16   ` Roland Stigge
2012-06-07 16:01     ` Jonathan Cameron [this message]
2012-06-07 10:15 ` [PATCH 1/2] iio: remove indio_dev pointer from max517_data Roland Stigge
2012-06-07 16:01   ` Jonathan Cameron
  -- strict thread matches above, loose matches on Subject: below --
2012-06-08  6:54 Peter Meerwald
2012-06-08  6:54 ` [PATCH 2/2] iio: max517: mark probe() and remove() with __devinit and __devexit Peter Meerwald

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FD0D04A.6050504@kernel.org \
    --to=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=stigge@antcom.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.